Skip to content

Commit 7fe94df

Browse files
committed
add a unit test
1 parent 6424ed6 commit 7fe94df

File tree

5 files changed

+33
-8
lines changed

5 files changed

+33
-8
lines changed
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
CREATE VIEW in_subquery WITH (security_invoker = TRUE) AS
2+
SELECT
3+
*
4+
FROM series
5+
WHERE series_id IN (
6+
SELECT
7+
series_id
8+
FROM series
9+
);
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
DROP VIEW in_subquery;
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
SELECT
2+
*
3+
FROM (
4+
SELECT
5+
*
6+
FROM series
7+
WHERE series_id IN (
8+
SELECT
9+
series_id
10+
FROM series
11+
)
12+
);
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
SELECT
2+
*
3+
FROM in_subquery;

ydb/core/kqp/ut/view/view_ut.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -139,10 +139,10 @@ void CompareResults(const NQuery::TExecuteQueryResult& first, const NQuery::TExe
139139
CompareResults(first.GetResultSets(), second.GetResultSets());
140140
}
141141

142-
void InitializeTablesAndSecondaryViews(TSession& session) {
142+
void InitializeTablesAndSecondaryViews(NQuery::TSession& session) {
143143
const auto inputFolder = ArcadiaFromCurrentLocation(__SOURCE_FILE__, "input");
144-
ExecuteDataDefinitionQuery(session, ReadWholeFile(inputFolder + "/create_tables_and_secondary_views.sql"));
145-
ExecuteDataModificationQuery(session, ReadWholeFile(inputFolder + "/fill_tables.sql"));
144+
ExecuteQuery(session, ReadWholeFile(inputFolder + "/create_tables_and_secondary_views.sql"));
145+
ExecuteQuery(session, ReadWholeFile(inputFolder + "/fill_tables.sql"));
146146
}
147147

148148
}
@@ -582,7 +582,7 @@ Y_UNIT_TEST_SUITE(TSelectFromViewTest) {
582582
Y_UNIT_TEST(ReadTestCasesFromFiles) {
583583
TKikimrRunner kikimr;
584584
EnableViewsFeatureFlag(kikimr);
585-
auto session = kikimr.GetTableClient().CreateSession().GetValueSync().GetSession();
585+
auto session = kikimr.GetQueryClient().GetSession().ExtractValueSync().GetSession();
586586

587587
InitializeTablesAndSecondaryViews(session);
588588
EnableLogging();
@@ -593,13 +593,13 @@ Y_UNIT_TEST_SUITE(TSelectFromViewTest) {
593593
TString testcase;
594594
while (testcase = testcases.Next()) {
595595
const auto pathPrefix = TStringBuilder() << testcasesFolder << '/' << testcase << '/';
596-
ExecuteDataDefinitionQuery(session, ReadWholeFile(pathPrefix + "create_view.sql"));
596+
ExecuteQuery(session, ReadWholeFile(pathPrefix + "create_view.sql"));
597597

598-
const auto etalonResults = ExecuteDataModificationQuery(session, ReadWholeFile(pathPrefix + "etalon_query.sql"));
599-
const auto selectFromViewResults = ExecuteDataModificationQuery(session, ReadWholeFile(pathPrefix + "select_from_view.sql"));
598+
const auto etalonResults = ExecuteQuery(session, ReadWholeFile(pathPrefix + "etalon_query.sql"));
599+
const auto selectFromViewResults = ExecuteQuery(session, ReadWholeFile(pathPrefix + "select_from_view.sql"));
600600
CompareResults(etalonResults, selectFromViewResults);
601601

602-
ExecuteDataDefinitionQuery(session, ReadWholeFile(pathPrefix + "drop_view.sql"));
602+
ExecuteQuery(session, ReadWholeFile(pathPrefix + "drop_view.sql"));
603603
}
604604
}
605605

0 commit comments

Comments
 (0)