Skip to content

Commit 7f0e2c0

Browse files
committed
Merge fixes
1 parent c030343 commit 7f0e2c0

File tree

6 files changed

+8
-7
lines changed

6 files changed

+8
-7
lines changed

ydb/core/tx/datashard/datashard.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2822,6 +2822,7 @@ void TDataShard::ProposeTransaction(TEvDataShard::TEvProposeTransaction::TPtr &&
28222822
Execute(tx, ctx, tx->GetTraceId());
28232823
}
28242824
}
2825+
28252826
void TDataShard::ProposeTransaction(NEvents::TDataEvents::TEvWrite::TPtr&& ev, const TActorContext& ctx) {
28262827
auto* msg = ev->Get();
28272828
const auto& record = msg->Record;

ydb/core/tx/datashard/datashard__progress_tx.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ bool TDataShard::TTxProgressTransaction::Execute(TTransactionContext &txc, const
6060
<< ActiveOp->GetCurrentUnit() << ") at " << Self->TabletID());
6161
ActiveOp->IncrementInProgress();
6262

63-
if (ActiveOp->TransactionSpan) {
63+
if (ActiveOp->OperationSpan) {
6464
if (!txc.Seat.TxSpan) {
6565
// If Progress Tx for this operation is being executed the first time,
6666
// it won't have a span, because we choose what operation to run in the transaction itself.

ydb/core/tx/datashard/datashard__read_iterator.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2107,7 +2107,7 @@ class TDataShard::TTxReadViaPipeline : public NTabletFlatExecutor::TTransactionB
21072107

21082108
const ui64 tieBreaker = Self->NextTieBreakerIndex++;
21092109
Op = new TReadOperation(Self, ctx.Now(), tieBreaker, Ev);
2110-
Op->TransactionSpan = NWilson::TSpan(TWilsonTablet::Tablet, readSpan.GetTraceId(), "ReadIterator.ReadOperation", NWilson::EFlags::AUTO_END);
2110+
Op->OperationSpan = NWilson::TSpan(TWilsonTablet::Tablet, readSpan.GetTraceId(), "ReadIterator.ReadOperation", NWilson::EFlags::AUTO_END);
21112111

21122112
Op->BuildExecutionPlan(false);
21132113
Self->Pipeline.GetExecutionUnit(Op->GetCurrentUnit()).AddOperation(Op);

ydb/core/tx/datashard/datashard_pipeline.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1323,7 +1323,7 @@ TActiveTransaction::TPtr TPipeline::BuildOperation(TEvDataShard::TEvProposeTrans
13231323
tx->SetTxBody(rec.GetTxBody());
13241324
tx->SetCookie(ev->Cookie);
13251325
tx->Orbit = std::move(ev->Get()->Orbit);
1326-
tx->TransactionSpan = NWilson::TSpan(TWilsonTablet::Tablet, std::move(traceId), "ActiveTransaction.Operation", NWilson::EFlags::AUTO_END);
1326+
tx->OperationSpan = NWilson::TSpan(TWilsonTablet::Tablet, std::move(traceId), "ActiveTransaction.Operation", NWilson::EFlags::AUTO_END);
13271327

13281328
auto malformed = [&](const TStringBuf txType, const TString& txBody) {
13291329
const TString error = TStringBuilder() << "Malformed " << txType << " tx"

ydb/core/tx/datashard/datashard_pipeline.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -265,11 +265,11 @@ class TPipeline : TNonCopyable {
265265
TActiveTransaction::TPtr BuildOperation(TEvDataShard::TEvProposeTransaction::TPtr &ev,
266266
TInstant receivedAt, ui64 tieBreakerIndex,
267267
NTabletFlatExecutor::TTransactionContext &txc,
268-
const TActorContext &ctx);
268+
const TActorContext &ctx, NWilson::TTraceId traceId);
269269
TOperation::TPtr BuildOperation(NEvents::TDataEvents::TEvWrite::TPtr &ev,
270270
TInstant receivedAt, ui64 tieBreakerIndex,
271271
NTabletFlatExecutor::TTransactionContext &txc,
272-
const TActorContext &ctx, NWilson::TTraceId traceId);
272+
const TActorContext &ctx);
273273
void BuildDataTx(TActiveTransaction *tx,
274274
TTransactionContext &txc,
275275
const TActorContext &ctx);

ydb/core/tx/datashard/operation.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -807,7 +807,7 @@ class TOperation
807807
void SetFinishProposeTs() noexcept;
808808

809809
NWilson::TTraceId GetTraceId() const noexcept {
810-
return TransactionSpan.GetTraceId();
810+
return OperationSpan.GetTraceId();
811811
}
812812

813813
protected:
@@ -889,7 +889,7 @@ class TOperation
889889
// Orbit used for tracking operation progress
890890
NLWTrace::TOrbit Orbit;
891891

892-
NWilson::TSpan TransactionSpan;
892+
NWilson::TSpan OperationSpan;
893893
};
894894

895895
inline IOutputStream &operator <<(IOutputStream &out,

0 commit comments

Comments
 (0)