remove optional from read_session_id field

Author: niksaveliev

ydb/public/api/protos/ydb_topic.proto

@@ -754,8 +754,8 @@ message CommitOffsetRequest {
     string consumer = 4;
     // Processed offset.
     int64 offset = 5;
-    // Read session identifier.
-    optional string read_session_id = 6;
+    // Read session identifier from StreamRead RPC.
+    string read_session_id = 6;
 }
 
 // Commit offset response sent from server to client.

ydb/services/persqueue_v1/actors/commit_offset_actor.cpp

@@ -106,7 +106,7 @@ void TCommitOffsetActor::Handle(TEvPQProxy::TEvAuthResultOk::TPtr& ev, const TAc
     if (partitionNode->AllParents.size() == 0 && partitionNode->DirectChildren.size() == 0) {
         SendCommit(topicInitInfo, commitRequest, ctx);
     } else {
-        auto killReadSession = !(commitRequest->has_read_session_id() && !commitRequest->read_session_id().empty());
+        auto killReadSession = commitRequest->read_session_id().empty();
         std::vector<TDistributedCommitHelper::TCommitInfo> commits;
 
         for (auto& parent: partitionNode->AllParents) {
@@ -121,7 +121,7 @@ void TCommitOffsetActor::Handle(TEvPQProxy::TEvAuthResultOk::TPtr& ev, const TAc
 
         TDistributedCommitHelper::TCommitInfo commit {.PartitionId = partitionNode->Id, .Offset = commitRequest->offset(), .KillReadSession = killReadSession, .OnlyCheckCommitedToFinish = false};
 
-        if (commitRequest->has_read_session_id() && !commitRequest->read_session_id().empty()) {
+        if (!commitRequest->read_session_id().empty()) {
             commit.ReadSessionId = commitRequest->read_session_id();
         }
         commits.push_back(commit);
@@ -200,7 +200,7 @@ void TCommitOffsetActor::SendCommit(const TTopicInitInfo& topic, const Ydb::Topi
     commit->SetClientId(ClientId);
     commit->SetOffset(commitRequest->offset());
     commit->SetStrict(true);
-    if (commitRequest->has_read_session_id() && !commitRequest->read_session_id().empty()) {
+    if (!commitRequest->read_session_id().empty()) {
         commit->SetSessionId(commitRequest->read_session_id());
     }