Added output of success statuses with issues in CLI (#9819)

Author: Gazizonoki

ydb/public/lib/ydb_cli/commands/query_workload.cpp

@@ -123,12 +123,8 @@ int TCommandQueryWorkloadRun::Run(TConfig& config) {
                     while (!IsInterrupted())
                     {
                         auto streamPart = result.ReadNext().GetValueSync();
-                        if (!streamPart.IsSuccess()) {
-                            if (streamPart.EOS()) {
-                                break;
-                            }
-
-                            ThrowOnError(streamPart);
+                        if (ThrowOnErrorAndCheckEOS(streamPart)) {
+                            break;
                         }
 
                         if (streamPart.GetStats()) {

ydb/public/lib/ydb_cli/commands/ydb_common.h

@@ -34,5 +34,17 @@ inline void ThrowOnError(const NYdb::TOperation& operation) {
     ThrowOnError(operation.Status());
 }
 
+inline bool ThrowOnErrorAndCheckEOS(NYdb::TStreamPartStatus status) {
+    if (!status.IsSuccess()) {
+        if (status.EOS()) {
+            return true;
+        }
+        throw TYdbErrorException(status) << static_cast<TStatus>(status);
+    } else if (status.GetIssues()) {
+        Cerr << static_cast<TStatus>(status);
+    }
+    return false;
+}
+
 }
 }

ydb/public/lib/ydb_cli/commands/ydb_service_table.cpp

@@ -746,11 +746,8 @@ bool TCommandExecuteQuery::PrintQueryResponse(TIterator& result) {
 
         while (!IsInterrupted()) {
             auto streamPart = result.ReadNext().GetValueSync();
-            if (!streamPart.IsSuccess()) {
-                if (streamPart.EOS()) {
-                    break;
-                }
-                ThrowOnError(streamPart);
+            if (ThrowOnErrorAndCheckEOS(streamPart)) {
+                break;
             }
 
             if (streamPart.HasResultSet()) {
@@ -896,11 +893,8 @@ int TCommandExplain::Run(TConfig& config) {
         SetInterruptHandlers();
         while (!IsInterrupted()) {
             auto tablePart = result.ReadNext().GetValueSync();
-            if (!tablePart.IsSuccess()) {
-                if (tablePart.EOS()) {
-                    break;
-                }
-                ThrowOnError(tablePart);
+            if (ThrowOnErrorAndCheckEOS(tablePart)) {
+                break;
             }
             if (tablePart.HasQueryStats()) {
                 auto proto = NYdb::TProtoAccessor::GetProto(tablePart.GetQueryStats());
@@ -939,11 +933,8 @@ int TCommandExplain::Run(TConfig& config) {
         SetInterruptHandlers();
         while (!IsInterrupted()) {
             auto tablePart = result.ReadNext().GetValueSync();
-            if (!tablePart.IsSuccess()) {
-                if (tablePart.EOS()) {
-                    break;
-                }
-                ThrowOnError(tablePart);
+            if (ThrowOnErrorAndCheckEOS(tablePart)) {
+                break;
             }
             if (tablePart.GetStats()) {
                 auto proto = NYdb::TProtoAccessor::GetProto(*tablePart.GetStats());
@@ -1179,12 +1170,9 @@ void TCommandReadTable::PrintResponse(NTable::TTablePartIterator& result) {
 
     while (!IsInterrupted()) {
         auto tablePart = result.ReadNext().GetValueSync();
-        if (!tablePart.IsSuccess()) {
-            if (tablePart.EOS()) {
+        if (ThrowOnErrorAndCheckEOS(tablePart)) {
                 break;
             }
-            ThrowOnError(tablePart);
-        }
         if (CountOnly) {
             TResultSetParser parser(tablePart.ExtractPart());
             while (parser.TryNextRow()) {

ydb/public/lib/ydb_cli/commands/ydb_sql.cpp

@@ -125,11 +125,8 @@ int TCommandSql::PrintResponse(NQuery::TExecuteQueryIterator& result) {
 
         while (!IsInterrupted()) {
             auto streamPart = result.ReadNext().GetValueSync();
-            if (!streamPart.IsSuccess()) {
-                if (streamPart.EOS()) {
-                    break;
-                }
-                ThrowOnError(streamPart);
+            if (ThrowOnErrorAndCheckEOS(streamPart)) {
+                break;
             }
 
             if (streamPart.HasResultSet() && !ExplainAnalyzeMode) {

ydb/public/lib/ydb_cli/commands/ydb_yql.cpp

@@ -145,11 +145,8 @@ bool TCommandYql::PrintResponse(NScripting::TYqlResultPartIterator& result) {
 
         while (!IsInterrupted()) {
             auto streamPart = result.ReadNext().GetValueSync();
-            if (!streamPart.IsSuccess()) {
-                if (streamPart.EOS()) {
-                    break;
-                }
-                ThrowOnError(streamPart);
+            if (ThrowOnErrorAndCheckEOS(streamPart)) {
+                break;
             }
 
             if (streamPart.HasPartialResult()) {