Moved Parse method to appropriate WorkloadRunCommand class & added interval validation

Author: Emgariko

ydb/library/workload/log/log.cpp

@@ -286,6 +286,7 @@ class TRandomLogGenerator {
         for (size_t row = 0; row < count; ++row) {
             result.emplace_back();
             result.back().LogId = CreateGuidAsString().c_str();
+            // TODO: check if it's correct to get interval params here
             result.back().Ts = Params.TimestampDateFrom.has_value() ? UniformInstant(*Params.TimestampDateFrom, *Params.TimestampDateTo) : RandomInstant();
             result.back().Level = RandomNumber<ui32>(10);
             result.back().ServiceName = RandomWord(false);
@@ -486,6 +487,15 @@ void TLogWorkloadParams::Parse(NYdb::NConsoleClient::TClientCommand::TConfig& co
     if ((date_from_passed && !date_to_passed) || (!date_from_passed && date_to_passed)) {
         throw yexception() << "The `date_from` and `date_to` parameters must be provided together to specify the interval for uniform PK generation";
     }
+
+    if (date_from_passed && date_to_passed) {
+        auto date_from_val = config.ParseResult->Get("date_from");
+        auto date_to_val = config.ParseResult->Get("date_to");
+
+        if (date_from_val >= date_to_val) {
+            throw yexception() << "Invalid interval [`date_from`, `date_to`)";
+        }
+    }
 }
 
 THolder<IWorkloadQueryGenerator> TLogWorkloadParams::CreateGenerator() const {

ydb/public/lib/ydb_cli/commands/ydb_workload.cpp

@@ -359,6 +359,10 @@ void TWorkloadCommandRun::Config(TConfig& config) {
     Params.ConfigureOpts(config.Opts->GetOpts(), NYdbWorkload::TWorkloadParams::ECommandType::Run, Type);
 }
 
+void TWorkloadCommandRun::Parse(TConfig& config) {
+    Params.Parse(config);
+}
+
 TWorkloadCommandBase::TWorkloadCommandBase(const TString& name, NYdbWorkload::TWorkloadParams& params, const NYdbWorkload::TWorkloadParams::ECommandType commandType, const TString& description, int type)
     : TYdbCommand(name, std::initializer_list<TString>(), description)
     , CommandType(commandType)
@@ -374,10 +378,6 @@ void TWorkloadCommandBase::Config(TConfig& config) {
     Params.ConfigureOpts(config.Opts->GetOpts(), CommandType, Type);
 }
 
-void TWorkloadCommandBase::Parse(TConfig& config) {
-    Params.Parse(config);
-}
-
 int TWorkloadCommandBase::Run(TConfig& config) {
     Driver = MakeHolder<NYdb::TDriver>(CreateDriver(config));
     if (!DryRun) {

ydb/public/lib/ydb_cli/commands/ydb_workload.h

@@ -73,6 +73,7 @@ class TWorkloadCommandRun : public TWorkloadCommand {
 public:
     TWorkloadCommandRun(NYdbWorkload::TWorkloadParams& params, const NYdbWorkload::IWorkloadQueryGenerator::TWorkloadType& workload);
     virtual void Config(TConfig& config) override;
+    virtual void Parse(TConfig& config) override;
     virtual int Run(TConfig& config) override;
 
 private:
@@ -89,7 +90,6 @@ class TWorkloadCommandBase: public TYdbCommand {
         const TString& description = TString(),
         int type = 0);
     virtual void Config(TConfig& config) override;
-    virtual void Parse(TConfig& config) override;
     virtual int Run(TConfig& config) override final;
 
 protected: