return calculation of slow disks

Author: kruall

ydb/core/blobstorage/dsproxy/dsproxy_patch.cpp

@@ -94,7 +94,6 @@ class TBlobStorageGroupPatchRequest : public TBlobStorageGroupRequestActor {
     bool IsGoodPatchedBlobId = false;
     bool IsAllowedErasure = false;
     bool IsSecured = false;
-    bool IsAccelerated = false;
     bool HasSlowVDisk = false;
     bool IsContinuedVPatch = false;
     bool IsMovedPatch = false;
@@ -593,8 +592,7 @@ class TBlobStorageGroupPatchRequest : public TBlobStorageGroupRequestActor {
         PATCH_LOG(PRI_DEBUG, BS_PROXY_PATCH, BPPA09, "Start Moved strategy",
                 (SentStarts, SentStarts));
         ScheduleWakeUp(StartTime, MovedPatchTag);
-        Become(&TThis::MovedPatchState);
-        TInstant movedPatchDeadline = Deadline;
+        Become(&TBlobStorageGroupPatchRequest::MovedPatchState);
         IsMovedPatch = true;
         ui32 subgroupIdx = 0;
 
@@ -620,7 +618,7 @@ class TBlobStorageGroupPatchRequest : public TBlobStorageGroupRequestActor {
 
         ui64 cookie = ((ui64)OriginalId.Hash() << 32) | PatchedId.Hash();
         events.emplace_back(new TEvBlobStorage::TEvVMovedPatch(OriginalGroupId.GetRawId(), Info->GroupID.GetRawId(),
-                OriginalId, PatchedId, vDisk, false, cookie, movedPatchDeadline));
+                OriginalId, PatchedId, vDisk, false, cookie, Deadline));
         events.back()->Orbit = std::move(Orbit);
         for (ui64 diffIdx = 0; diffIdx < DiffCount; ++diffIdx) {
             auto &diff = Diffs[diffIdx];
@@ -660,7 +658,7 @@ class TBlobStorageGroupPatchRequest : public TBlobStorageGroupRequestActor {
 
     void StartVPatch() {
         StageStart = TActivationContext::Now();
-        Become(&TThis::VPatchState);
+        Become(&TBlobStorageGroupPatchRequest::VPatchState);
         Info->PickSubgroup(OriginalId.Hash(), &VDisks, nullptr);
         ReceivedResponseFlags.assign(VDisks.size(), false);
         ErrorResponseFlags.assign(VDisks.size(), false);
@@ -864,23 +862,6 @@ class TBlobStorageGroupPatchRequest : public TBlobStorageGroupRequestActor {
         return true;
     }
 
-    void GetWorstPredictedDelaysNs(NKikimrBlobStorage::EVDiskQueueId queueId,
-            ui64 *outWorstNs, ui64 *outNextToWorstNs, i32 *outWorstSubgroupIdx) const {
-        *outWorstSubgroupIdx = -1;
-        *outWorstNs = 0;
-        *outNextToWorstNs = 0;
-        for (ui32 diskIdx = 0; diskIdx < VDisks.size(); ++diskIdx) {
-            ui64 predictedNs = GroupQueues->GetPredictedDelayNsByOrderNumber(diskIdx, queueId);;
-            if (predictedNs > *outWorstNs) {
-                *outNextToWorstNs = *outWorstNs;
-                *outWorstNs = predictedNs;
-                *outWorstSubgroupIdx = diskIdx;
-            } else if (predictedNs > *outNextToWorstNs) {
-                *outNextToWorstNs = predictedNs;
-            }
-        }
-    }
-
     void Bootstrap() override {
         PATCH_LOG(PRI_DEBUG, BS_PROXY_PATCH, BPPA01, "Actor bootstrapped");
         Schedule(TDuration::MicroSeconds(60'000'000), new TEvents::TEvWakeup(NeverTag));
@@ -927,15 +908,26 @@ class TBlobStorageGroupPatchRequest : public TBlobStorageGroupRequestActor {
         }
     }
 
+    void SetSlowDisks() {
+        for (ui32 idx = 0; idx < SlowFlags.size(); ++idx) {
+            SlowFlags[idx] = !ReceivedResponseFlags[idx] && !EmptyResponseFlags[idx] && !ErrorResponseFlags[idx];
+            if (SlowFlags[idx]) {
+                HasSlowVDisk = true;
+            }
+        }
+    }
+
     template <ui64 ExpectedTag>
     void HandleWakeUp(TEvents::TEvWakeup::TPtr &ev) {
         PATCH_LOG(PRI_DEBUG, BS_PROXY_PATCH, BPPA36, "HandleWakeUp",
                 (ExpectedTag, ToString(ExpectedTag)),
                 (ReceivedTag, ToString(ev->Get()->Tag)));
         if (ev->Get()->Tag == ExpectedTag) {
+            SetSlowDisks();
             StartFallback();
         }
         if (ev->Get()->Tag == NeverTag) {
+            SetSlowDisks();
             StartFallback();
             PATCH_LOG(PRI_DEBUG, BS_PROXY_PATCH, BPPA40, "Found NeverTag wake up", (ExpectedTag, ToString(ExpectedTag)));
         }
@@ -947,9 +939,11 @@ class TBlobStorageGroupPatchRequest : public TBlobStorageGroupRequestActor {
                 (ExpectedTag, ToString(expectedTag)),
                 (ReceivedTag, ToString(ev->Get()->Tag)));
         if (ev->Get()->Tag == expectedTag) {
+            SetSlowDisks();
             StartFallback();
         }
         if (ev->Get()->Tag == NeverTag) {
+            SetSlowDisks();
             StartFallback();
             PATCH_LOG(PRI_DEBUG, BS_PROXY_PATCH, BPPA41, "Found NeverTag wake up", (ExpectedTag, ToString(expectedTag)));
         }