[CBO] Hints warning messages improvement

Author: pashandor789

ydb/core/kqp/opt/logical/kqp_opt_log.cpp

@@ -92,8 +92,10 @@ class TKqpLogicalOptTransformer : public TOptimizeTransformerBase {
     TStatus DoTransform(TExprNode::TPtr input, TExprNode::TPtr& output, TExprContext& ctx) override {
         auto status = TOptimizeTransformerBase::DoTransform(input, output, ctx);
 
-        for (const auto& hint: KqpCtx.GetOptimizerHints().GetUnappliedString()) {
-            ctx.AddWarning(YqlIssue({}, TIssuesIds::YQL_UNUSED_HINT, "Unapplied hint: " + hint));
+        if (status == TStatus::Ok) {
+            for (const auto& hint: KqpCtx.GetOptimizerHints().GetUnappliedString()) {
+                ctx.AddWarning(YqlIssue({}, TIssuesIds::YQL_UNUSED_HINT, "Unapplied hint: " + hint));
+            }
         }
 
         return status;

ydb/library/yql/core/cbo/cbo_hints.cpp

@@ -46,9 +46,9 @@ class TOptimizerHintsParser {
     }
 
     void JoinAlgo() {        
-        Keyword({"("});
-
         i32 beginPos = Pos + 1;
+        
+        Keyword({"("});
 
         i32 labelsBeginPos = Pos + 1;
         TVector<TString> labels = CollectLabels();
@@ -65,7 +65,7 @@ class TOptimizerHintsParser {
 
         for (const auto& [joinAlgo, joinAlgoStr]: Zip(joinAlgos, joinAlgosStr)) {
             if (reqJoinAlgoStr == joinAlgoStr) {
-                Hints.JoinAlgoHints->PushBack(std::move(labels), joinAlgo, "JoinOrder" + Text.substr(beginPos, Pos - beginPos + 1));
+                Hints.JoinAlgoHints->PushBack(std::move(labels), joinAlgo, "JoinAlgo" + Text.substr(beginPos, Pos - beginPos + 1));
                 return;
             }
         }