Skip to content

Commit 48ef3e7

Browse files
authored
Merge 091981c into f38e450
2 parents f38e450 + 091981c commit 48ef3e7

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

ydb/services/lib/actors/pq_schema_actor.cpp

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -594,8 +594,12 @@ namespace NKikimr::NGRpcProxy::V1 {
594594
}
595595

596596
std::optional<TYdbPqCodes> ValidatePartitionStrategy(const ::NKikimrPQ::TPQTabletConfig& config, TString& error) {
597-
if (!config.has_partitionstrategy())
597+
if (!config.HasPartitionStrategy()) {
598598
return std::nullopt;
599+
}
600+
if (::NKikimrPQ::TPQTabletConfig_TPartitionStrategyType::TPQTabletConfig_TPartitionStrategyType_DISABLED == config.GetPartitionStrategy().GetPartitionStrategyType()) {
601+
return std::nullopt;
602+
}
599603
auto strategy = config.GetPartitionStrategy();
600604
if (strategy.GetMinPartitionCount() < 0) {
601605
error = TStringBuilder() << "Partitions count must be non-negative, provided " << strategy.GetMinPartitionCount();
@@ -622,7 +626,7 @@ namespace NKikimr::NGRpcProxy::V1 {
622626
error = TStringBuilder() << "Partition scale threshold time must be greater then 1 second, provided " << strategy.GetScaleThresholdSeconds() << " seconds";
623627
return TYdbPqCodes(Ydb::StatusIds::BAD_REQUEST, Ydb::PersQueue::ErrorCode::VALIDATION_ERROR);
624628
}
625-
if (strategy.GetPartitionStrategyType() != ::NKikimrPQ::TPQTabletConfig_TPartitionStrategyType::TPQTabletConfig_TPartitionStrategyType_DISABLED && config.GetPartitionConfig().HasStorageLimitBytes()) {
629+
if (config.GetPartitionConfig().HasStorageLimitBytes()) {
626630
error = TStringBuilder() << "Auto partitioning is incompatible with retention storage bytes option";
627631
return TYdbPqCodes(Ydb::StatusIds::BAD_REQUEST, Ydb::PersQueue::ErrorCode::VALIDATION_ERROR);
628632
}

0 commit comments

Comments
 (0)