Skip to content

Commit 4365df4

Browse files
committed
fix table description
1 parent e6af722 commit 4365df4

File tree

1 file changed

+14
-20
lines changed

1 file changed

+14
-20
lines changed

ydb/core/ydb_convert/table_description.cpp

Lines changed: 14 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,6 @@ THashSet<EAlterOperationKind> GetAlterOperationKinds(const Ydb::Table::AlterTabl
4848
req->alter_columns_size() ||
4949
req->ttl_action_case() !=
5050
Ydb::Table::AlterTableRequest::TTL_ACTION_NOT_SET ||
51-
req->tiering_action_case() !=
52-
Ydb::Table::AlterTableRequest::TIERING_ACTION_NOT_SET ||
5351
req->has_alter_storage_settings() || req->add_column_families_size() ||
5452
req->alter_column_families_size() || req->set_compaction_policy() ||
5553
req->has_alter_partitioning_settings() ||
@@ -509,11 +507,22 @@ Ydb::Type* AddColumn<NKikimrSchemeOp::TColumnDescription>(Ydb::Table::ColumnMeta
509507

510508
template <typename TYdbProto, typename TTtl>
511509
static void AddTtl(TYdbProto& out, const TTtl& inTTL) {
510+
static const auto& fillCommonFields = []<class TModeSettings>(TModeSettings& out, const TTtl& in) {
511+
out.set_column_name(in.GetColumnName());
512+
if (in.HasExpireAfterSeconds()) {
513+
out.set_expire_after_seconds(in.GetExpireAfterSeconds());
514+
}
515+
for (const auto& in_tier : in.GetTiers()) {
516+
auto* out_tier = out.add_storage_tiers();
517+
out_tier->set_evict_after_seconds(in_tier.GetEvictAfterSeconds());
518+
out_tier->set_storage_name(in_tier.GetStorageName());
519+
}
520+
};
521+
512522
switch (inTTL.GetColumnUnit()) {
513523
case NKikimrSchemeOp::TTTLSettings::UNIT_AUTO: {
514524
auto& outTTL = *out.mutable_ttl_settings()->mutable_date_type_column();
515-
outTTL.set_column_name(inTTL.GetColumnName());
516-
outTTL.set_expire_after_seconds(inTTL.GetExpireAfterSeconds());
525+
fillCommonFields(outTTL, inTTL);
517526
break;
518527
}
519528

@@ -522,9 +531,8 @@ static void AddTtl(TYdbProto& out, const TTtl& inTTL) {
522531
case NKikimrSchemeOp::TTTLSettings::UNIT_MICROSECONDS:
523532
case NKikimrSchemeOp::TTTLSettings::UNIT_NANOSECONDS: {
524533
auto& outTTL = *out.mutable_ttl_settings()->mutable_value_since_unix_epoch();
525-
outTTL.set_column_name(inTTL.GetColumnName());
534+
fillCommonFields(outTTL, inTTL);
526535
outTTL.set_column_unit(static_cast<Ydb::Table::ValueSinceUnixEpochModeSettings::Unit>(inTTL.GetColumnUnit()));
527-
outTTL.set_expire_after_seconds(inTTL.GetExpireAfterSeconds());
528536
break;
529537
}
530538

@@ -572,10 +580,6 @@ void FillColumnDescriptionImpl(TYdbProto& out,
572580
if (in.GetTTLSettings().HasEnabled()) {
573581
AddTtl(out, in.GetTTLSettings().GetEnabled());
574582
}
575-
576-
if (in.GetTTLSettings().HasUseTiering()) {
577-
out.set_tiering(in.GetTTLSettings().GetUseTiering());
578-
}
579583
}
580584
}
581585

@@ -612,10 +616,6 @@ void FillColumnDescription(Ydb::Table::DescribeTableResult& out, const NKikimrSc
612616
if (in.GetTtlSettings().HasEnabled()) {
613617
AddTtl(out, in.GetTtlSettings().GetEnabled());
614618
}
615-
616-
if (in.GetTtlSettings().HasUseTiering()) {
617-
out.set_tiering(in.GetTtlSettings().GetUseTiering());
618-
}
619619
}
620620

621621
out.set_store_type(Ydb::Table::StoreType::STORE_TYPE_COLUMN);
@@ -829,12 +829,6 @@ bool BuildAlterColumnTableModifyScheme(const TString& path, const Ydb::Table::Al
829829
} else if (req->has_drop_ttl_settings()) {
830830
alterColumnTable->MutableAlterTtlSettings()->MutableDisabled();
831831
}
832-
833-
if (req->has_set_tiering()) {
834-
alterColumnTable->MutableAlterTtlSettings()->SetUseTiering(req->set_tiering());
835-
} else if (req->has_drop_tiering()) {
836-
alterColumnTable->MutableAlterTtlSettings()->SetUseTiering("");
837-
}
838832
}
839833

840834
return true;

0 commit comments

Comments
 (0)