fix concurrent rw hash map (#9008) (#9041)

Author: alexd65536

ydb/core/control/immediate_control_board_impl.cpp

@@ -16,7 +16,7 @@ bool TControlBoard::RegisterLocalControl(TControlWrapper control, TString name)
 }
 
 bool TControlBoard::RegisterSharedControl(TControlWrapper& control, TString name) {
-    auto& ptr = Board.InsertIfAbsent(name, control.Control);
+    auto ptr = Board.InsertIfAbsent(name, control.Control);
     if (control.Control == ptr) {
         return true;
     } else {

ydb/core/tablet/private/aggregated_counters.h

@@ -140,7 +140,7 @@ class TAggregatedHistogramCounters {
     TVector<TCountersByTabletIdMap> CountersByTabletId; // each index is map from tablet to counter value
 };
 
-class TAggregatedLabeledCounters {
+class TAggregatedLabeledCounters : public TThrRefBase {
 public:
     //
     TAggregatedLabeledCounters(ui32 count, const ui8* aggrFunc, const char * const * names, const ui8* types, const TString& groupNames);

ydb/core/tablet/private/labeled_db_counters.cpp

@@ -31,7 +31,7 @@ void TPQCounters::Apply(ui64 tabletId, const NKikimr::TTabletLabeledCountersBase
         }
     }
 
-    auto& el = LabeledCountersByGroup.InsertIfAbsent(group, new TAggregatedLabeledCounters(
+    auto el = LabeledCountersByGroup.InsertIfAbsent(group, new TAggregatedLabeledCounters(
         labeledCounters->GetCounters().Size(), labeledCounters->GetAggrFuncs(),
         labeledCounters->GetNames(), labeledCounters->GetTypes(), groupNames));
 

ydb/core/tablet/private/labeled_db_counters.h

@@ -13,7 +13,7 @@ namespace NKikimr::NPrivate {
 
 class TPQCounters : public ILabeledCounters {
 protected:
-    TConcurrentRWHashMap<TString, TAutoPtr<TAggregatedLabeledCounters>, 256> LabeledCountersByGroup;
+    TConcurrentRWHashMap<TString, TIntrusivePtr<TAggregatedLabeledCounters>, 256> LabeledCountersByGroup;
     NMonitoring::TDynamicCounterPtr Group;
 
 public:

ydb/core/util/concurrent_rw_hash.h

@@ -49,15 +49,15 @@ class TConcurrentRWHashMap {
         bucket.Map[key] = value;
     }
 
-    V& InsertIfAbsent(const K& key, const V& value) {
+    V InsertIfAbsent(const K& key, const V& value) {
         TBucket& bucket = GetBucketForKey(key);
         TWriteGuard guard(bucket.RWLock);
 
         return bucket.Map.insert(std::make_pair(key, value)).first->second;
     }
 
     template <typename Callable>
-    V& InsertIfAbsentWithInit(const K& key, Callable initFunc) {
+    V InsertIfAbsentWithInit(const K& key, Callable initFunc) {
         TBucket& bucket = GetBucketForKey(key);
         TWriteGuard guard(bucket.RWLock);