Skip to content

Commit 3afcaf9

Browse files
authored
Added missing settings to query_service_config in local_ydb (#2021)
1 parent 126ee0c commit 3afcaf9

File tree

3 files changed

+16
-2
lines changed

3 files changed

+16
-2
lines changed

ydb/public/tools/lib/cmds/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ def generic_connector_config():
271271

272272
valid_schemes = ['grpc', 'grpcs']
273273
if parsed.scheme not in valid_schemes:
274-
raise ValueError("Invalid schema '{}' in FQ_CONNECTOR_ENDPOINT (possible: {})".format(parsed.schema, valid_schemes))
274+
raise ValueError("Invalid schema '{}' in FQ_CONNECTOR_ENDPOINT (possible: {})".format(parsed.scheme, valid_schemes))
275275

276276
cfg = TGenericConnectorConfig()
277277
cfg.Endpoint.host = parsed.hostname

ydb/tests/library/harness/kikimr_config.py

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,17 @@ def __init__(
397397
"port": generic_connector_config.Endpoint.port,
398398
},
399399
"use_ssl": generic_connector_config.UseSsl
400-
}
400+
},
401+
"default_settings": [
402+
{
403+
"name": "DateTimeFormat",
404+
"value": "string"
405+
},
406+
{
407+
"name": "UsePredicatePushdown",
408+
"value": "true"
409+
}
410+
]
401411
}
402412

403413
self.yaml_config["feature_flags"]["enable_external_data_sources"] = True

ydb/tests/library/ut/kikimr_config.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,9 @@ def test_kikimr_config_generator_generic_connector_config():
1515
assert yaml_config["query_service_config"]["generic"]["connector"]["endpoint"]["host"] == generic_connector_config.Endpoint.host
1616
assert yaml_config["query_service_config"]["generic"]["connector"]["endpoint"]["port"] == generic_connector_config.Endpoint.port
1717
assert yaml_config["query_service_config"]["generic"]["connector"]["use_ssl"] == generic_connector_config.UseSsl
18+
assert yaml_config["query_service_config"]["generic"]["default_settings"] == [
19+
{"name": "DateTimeFormat", "value": "string"},
20+
{"name": "UsePredicatePushdown", "value": "true"},
21+
]
1822
assert yaml_config["feature_flags"]["enable_external_data_sources"] is True
1923
assert yaml_config["feature_flags"]["enable_script_execution_operations"] is True

0 commit comments

Comments
 (0)