Fix for -2**63

Author: amikish

ydb/library/yql/minikql/invoke_builtins/mkql_builtins_mul.cpp

@@ -43,19 +43,20 @@ struct TNumMulInterval {
         if (rv == 0 || lv == 0) {
             return NUdf::TUnboxedValuePod(ret);
         }
+        i64 i64Max = std::numeric_limits<i64>::max();
         if constexpr (std::is_same_v<ui64, typename TLeft::TLayout>) {
-            if (left.Get<ui64>() > static_cast<ui64>(std::numeric_limits<i64>::max())) {
+            if (left.Get<ui64>() >= static_cast<ui64>(i64Max)) {
                 return NUdf::TUnboxedValuePod();
             }
         }
         if constexpr (std::is_same_v<ui64, typename TRight::TLayout>) {
-            if (right.Get<ui64>() > static_cast<ui64>(std::numeric_limits<i64>::max())) {
+            if (right.Get<ui64>() >= static_cast<ui64>(i64Max)) {
                 return NUdf::TUnboxedValuePod();
             }
         }
-        i64 lvAbs = (lv >= 0) ? lv : -lv;
-        i64 rvAbs = (rv >= 0) ? rv : -rv;
-        if (rvAbs != 0 && (std::numeric_limits<i64>::max() / rvAbs < lvAbs)) {
+        auto div = i64Max / rv;
+        auto divAbs = (div >= 0) ? div : -div;
+        if ((lv >= 0) ? (lv > divAbs) : (lv < -divAbs)) {
             return NUdf::TUnboxedValuePod();
         }
         return IsBadInterval<TOutput>(ret) ? NUdf::TUnboxedValuePod() : NUdf::TUnboxedValuePod(ret);
@@ -85,23 +86,26 @@ struct TNumMulInterval {
 
         block = bbMain;
 
-        const auto lhsAbs = SelectInst::Create(
-                CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_SGE, lhs, zero, "lhsPos", block),
-                lhs,
-                BinaryOperator::CreateNeg(lhs, "lhsNeg", block),
-                "lhsAbs", block);
-        const auto rhsAbs = SelectInst::Create(
-                CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_SGE, rhs, zero, "rhsPos", block),
-                rhs,
-                BinaryOperator::CreateNeg(rhs, "rhsNeg", block),
-                "rhsAbs", block);
         const auto i64Max = ConstantInt::get(Type::getInt64Ty(context), std::numeric_limits<i64>::max());
-        const auto div = BinaryOperator::CreateSDiv(i64Max, rhsAbs, "div", block);
-        const auto mulOverflow = CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_SGT, lhsAbs, div, "mulOverflow", block);
+        const auto div = BinaryOperator::CreateSDiv(i64Max, rhs, "div", block);
+        const auto divAbs = SelectInst::Create(
+                CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_SGE, div, zero, "divPos", block),
+                div,
+                BinaryOperator::CreateNeg(div, "divNeg", block),
+                "divAbs", block);
+        const auto divAbsNeg = BinaryOperator::CreateNeg(divAbs, "divAbsNeg", block);
+
+        const auto mulOverflow = SelectInst::Create(
+                CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_SGE, lhs, zero, "lhsPos", block),
+                CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_SGT, lhs, divAbs, "lhsDiv", block),
+                CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_SLT, lhs, divAbsNeg, "lhsDivAbsNeg", block),
+                "mulOverflow", block);
+
         const auto i64Overflow = BinaryOperator::CreateOr(
                 GenIsInt64Overflow<typename TLeft::TLayout>(lv, context, block),
                 GenIsInt64Overflow<typename TRight::TLayout>(rv, context, block),
                 "i64Overflow", block);
+
         const auto bad = BinaryOperator::CreateOr(
                 BinaryOperator::CreateOr(i64Overflow, mulOverflow, "overflow", block),
                 GenIsBadInterval<TOutput>(mul, context, block),

ydb/library/yql/tests/sql/hybrid_file/part7/canondata/result.json

@@ -519,9 +519,9 @@
     ],
     "test.test[bigdate-table_arithmetic_mul_div-default.txt-Debug]": [
         {
-            "checksum": "1491822b38492114abf81faa61617ed7",
+            "checksum": "e4b3b10b8e5b4327fbf645fdd5d954ef",
             "size": 30172,
-            "uri": "https://{canondata_backend}/1881367/9f7e60d9f0b51c840a9c35afc7adcd160edd3a99/resource.tar.gz#test.test_bigdate-table_arithmetic_mul_div-default.txt-Debug_/opt.yql_patched"
+            "uri": "https://{canondata_backend}/1946324/f50f0ddca01e8f702eb5a24b0934473d036b5007/resource.tar.gz#test.test_bigdate-table_arithmetic_mul_div-default.txt-Debug_/opt.yql_patched"
         }
     ],
     "test.test[bigdate-table_arithmetic_mul_div-default.txt-Plan]": [

ydb/library/yql/tests/sql/yt_native_file/part6/canondata/result.json

@@ -421,9 +421,9 @@
     ],
     "test.test[bigdate-table_arithmetic_mul_div-default.txt-Debug]": [
         {
-            "checksum": "0bd968024604066c96e2e0ca355b839c",
+            "checksum": "428a68b06c3b405e0087538758ca7e4c",
             "size": 24400,
-            "uri": "https://{canondata_backend}/1899731/7e12bbd97e6ef42ea9512918c50ff003ad37ded8/resource.tar.gz#test.test_bigdate-table_arithmetic_mul_div-default.txt-Debug_/opt.yql"
+            "uri": "https://{canondata_backend}/1917492/30b5bc2d6861ed60772eb6885e2fd9071a8898c0/resource.tar.gz#test.test_bigdate-table_arithmetic_mul_div-default.txt-Debug_/opt.yql"
         }
     ],
     "test.test[bigdate-table_arithmetic_mul_div-default.txt-Plan]": [
@@ -435,9 +435,9 @@
     ],
     "test.test[bigdate-table_arithmetic_mul_div-default.txt-Results]": [
         {
-            "checksum": "94ea4fca6d839c1bf7e0da1f0df49929",
-            "size": 662551,
-            "uri": "https://{canondata_backend}/1899731/7e12bbd97e6ef42ea9512918c50ff003ad37ded8/resource.tar.gz#test.test_bigdate-table_arithmetic_mul_div-default.txt-Results_/results.txt"
+            "checksum": "785fb2e27cc00e47a21316d75d79a7b5",
+            "size": 662203,
+            "uri": "https://{canondata_backend}/1917492/30b5bc2d6861ed60772eb6885e2fd9071a8898c0/resource.tar.gz#test.test_bigdate-table_arithmetic_mul_div-default.txt-Results_/results.txt"
         }
     ],
     "test.test[bigdate-table_arithmetic_narrow-default.txt-Debug]": [