fix filter reset and remove useless validation (#15312)

Author: ivanmorozov333

ydb/core/formats/arrow/program/aggr_keys.cpp

@@ -120,7 +120,6 @@ TConclusionStatus TWithKeysAggregationProcessor::DoExecute(
     }
     auto gbBatch = (*gbRes).record_batch();
     resources->Remove(AggregationKeys);
-    resources->ResetFilter();
 
     for (auto& assign : funcOpts.assigns) {
         auto column = gbBatch->GetColumnByName(assign.result_column);
@@ -180,7 +179,6 @@ TConclusionStatus TWithKeysAggregationProcessor::TBuilder::AddGroupBy(
 
 TConclusion<arrow::Datum> TAggregateFunction::Call(
     const TExecFunctionContext& context, const std::shared_ptr<TAccessorsCollection>& resources) const {
-    resources->ResetFilter();
     if (context.GetColumns().size() == 0 && AggregationType == NAggregation::EAggregate::NumRows) {
         auto rc = resources->GetRecordsCountActualOptional();
         if (!rc) {

ydb/core/formats/arrow/program/collection.cpp

@@ -19,9 +19,6 @@ void TAccessorsCollection::AddVerified(const ui32 columnId, const std::shared_pt
 
 void TAccessorsCollection::AddVerified(const ui32 columnId, const TAccessorCollectedContainer& data, const bool withFilter) {
     AFL_VERIFY(columnId);
-    if (!Filter->IsTotalAllowFilter()) {
-        AFL_VERIFY(!data.GetItWasScalar());
-    }
     if (UseFilter && withFilter && !Filter->IsTotalAllowFilter()) {
         auto filtered = Filter->Apply(data.GetData());
         RecordsCountActual = filtered->GetRecordsCount();

ydb/core/formats/arrow/program/collection.h

@@ -53,10 +53,6 @@ class TAccessorsCollection {
         return Accessors.size();
     }
 
-    void ResetFilter() {
-        Filter = std::make_shared<TColumnFilter>(TColumnFilter::BuildAllowFilter());
-    }
-
     std::optional<ui32> GetRecordsCountActualOptional() const {
         return RecordsCountActual;
     }