Skip to content

Commit 337c76d

Browse files
authored
Merge c53b071 into 8a1f080
2 parents 8a1f080 + c53b071 commit 337c76d

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

ydb/core/kqp/gateway/kqp_metadata_loader.cpp

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -754,7 +754,12 @@ NThreading::TFuture<TTableMetadataResult> TKqpTableMetadataLoader::LoadTableMeta
754754
const bool resolveEntityInsideDataSource = (cluster != Cluster);
755755
// resolveEntityInsideDataSource => entry.Kind == EKind::KindExternalDataSource
756756
if (resolveEntityInsideDataSource && entry.Kind != EKind::KindExternalDataSource) {
757-
throw yexception() << "\"" << CombinePath(entry.Path.begin(), entry.Path.end()) << "\" is expected to be external data source";
757+
const auto message = TStringBuilder()
758+
<< "\"" << CombinePath(entry.Path.begin(), entry.Path.end())
759+
<< "\" is expected to be external data source";
760+
761+
promise.SetValue(ResultFromError<TResult>(YqlIssue({}, TIssuesIds::KIKIMR_BAD_REQUEST, message)));
762+
return;
758763
}
759764

760765
switch (entry.Kind) {

ydb/core/kqp/ut/federated_query/s3/kqp_federated_query_ut.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1579,7 +1579,7 @@ Y_UNIT_TEST_SUITE(KqpFederatedQuery) {
15791579

15801580
auto db = kikimr->GetQueryClient();
15811581
auto queryExecutionOperation = db.ExecuteQuery(sql, NYdb::NQuery::TTxControl::BeginTx().CommitTx()).ExtractValueSync();
1582-
UNIT_ASSERT_VALUES_UNEQUAL_C(queryExecutionOperation.GetStatus(), EStatus::SUCCESS, queryExecutionOperation.GetIssues().ToString());
1582+
UNIT_ASSERT_EQUAL_C(queryExecutionOperation.GetStatus(), EStatus::BAD_REQUEST, static_cast<int>(queryExecutionOperation.GetStatus()) << ", " << queryExecutionOperation.GetIssues().ToString());
15831583
UNIT_ASSERT_STRING_CONTAINS(queryExecutionOperation.GetIssues().ToString(), "\"/Root/external_table\" is expected to be external data source");
15841584
}
15851585

@@ -1600,7 +1600,7 @@ Y_UNIT_TEST_SUITE(KqpFederatedQuery) {
16001600

16011601
auto db = kikimr->GetQueryClient();
16021602
auto queryExecutionOperation = db.ExecuteQuery(sql, NYdb::NQuery::TTxControl::BeginTx().CommitTx()).ExtractValueSync();
1603-
UNIT_ASSERT_VALUES_UNEQUAL_C(queryExecutionOperation.GetStatus(), EStatus::SUCCESS, queryExecutionOperation.GetIssues().ToString());
1603+
UNIT_ASSERT_EQUAL_C(queryExecutionOperation.GetStatus(), EStatus::BAD_REQUEST, static_cast<int>(queryExecutionOperation.GetStatus()) << ", " << queryExecutionOperation.GetIssues().ToString());
16041604
UNIT_ASSERT_STRING_CONTAINS(queryExecutionOperation.GetIssues().ToString(), "\"/Root/external_table\" is expected to be external data source");
16051605
}
16061606
}

0 commit comments

Comments
 (0)