Skip to content

Commit 2ab2a19

Browse files
committed
remove family action
1 parent eea3575 commit 2ab2a19

File tree

6 files changed

+9
-30
lines changed

6 files changed

+9
-30
lines changed

ydb/core/protos/flat_scheme_op.proto

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -224,16 +224,11 @@ message TTTLSettings {
224224
optional string StorageName = 1;
225225
}
226226

227-
message TEvictionToColumnFamilySettings {
228-
optional string FamilyName = 1;
229-
}
230-
231227
message TTier {
232228
optional uint32 EvictAfterSeconds = 1;
233229
oneof Action {
234230
google.protobuf.Empty Delete = 2;
235231
TEvictionToExternalStorageSettings EvictToExternalStorage = 3;
236-
TEvictionToColumnFamilySettings EvictToColumnFamily = 4;
237232
}
238233
}
239234

ydb/core/ydb_convert/table_description.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -534,9 +534,6 @@ static void AddTtl(TYdbProto& out, const TTtl& inTTL) {
534534
case NKikimrSchemeOp::TTTLSettings::TTier::ActionCase::kEvictToExternalStorage:
535535
outTier->mutable_evict_to_external_storage()->set_storage_name(inTier.GetEvictToExternalStorage().GetStorageName());
536536
break;
537-
case NKikimrSchemeOp::TTTLSettings::TTier::ActionCase::kEvictToColumnFamily:
538-
outTier->mutable_evict_to_column_family()->set_family_name(inTier.GetEvictToColumnFamily().GetFamilyName());
539-
break;
540537
case NKikimrSchemeOp::TTTLSettings::TTier::ActionCase::ACTION_NOT_SET:
541538
break;
542539
}

ydb/core/ydb_convert/table_settings.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,6 @@ bool FillTtlSettings(TTtlSettingsEnabled& out, const Ydb::Table::TtlSettings& in
4646
case Ydb::Table::TtlTier::kEvictToExternalStorage:
4747
outTier->MutableEvictToExternalStorage()->SetStorageName(inTier.evict_to_external_storage().storage_name());
4848
break;
49-
case Ydb::Table::TtlTier::kEvictToColumnFamily:
50-
outTier->MutableEvictToColumnFamily()->SetFamilyName(inTier.evict_to_column_family().family_name());
51-
break;
5249
case Ydb::Table::TtlTier::ACTION_NOT_SET:
5350
break;
5451
}

ydb/public/api/protos/ydb_table.proto

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -449,7 +449,6 @@ message TtlTier {
449449
oneof action {
450450
google.protobuf.Empty delete = 2;
451451
EvictionToExternalStorageSettings evict_to_external_storage = 3;
452-
EvictionToFamilySettings evict_to_column_family = 3;
453452
}
454453
}
455454

ydb/public/sdk/cpp/client/ydb_table/table.cpp

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525

2626
#include <library/cpp/cache/cache.h>
2727

28+
#include <util/generic/overloaded.h>
2829
#include <util/generic/map.h>
2930
#include <util/random/random.h>
3031
#include <util/string/join.h>
@@ -2950,9 +2951,6 @@ TTtlTierSettings::TTtlTierSettings(const Ydb::Table::TtlTier& tier)
29502951
case Ydb::Table::TtlTier::kEvictToExternalStorage:
29512952
Action_ = TTtlEvictToExternalStorageAction(tier.evict_to_external_storage().storage_name());
29522953
break;
2953-
case Ydb::Table::TtlTier::kEvictToColumnFamily:
2954-
Action_ = TTtlEvictToExternalStorageAction(tier.evict_to_column_family().family_name());
2955-
break;
29562954
case Ydb::Table::TtlTier::ACTION_NOT_SET:
29572955
break;
29582956
}
@@ -2961,17 +2959,14 @@ TTtlTierSettings::TTtlTierSettings(const Ydb::Table::TtlTier& tier)
29612959
void TTtlTierSettings::SerializeTo(Ydb::Table::TtlTier& proto) const {
29622960
proto.set_evict_after_seconds(EvictionDelay_.Seconds());
29632961

2964-
auto actionVisitor = [proto](auto&& action) mutable {
2965-
using T = std::decay_t<decltype(action)>;
2966-
if constexpr (std::is_same_v<T, TTtlDeleteAction>) {
2967-
proto.mutable_delete_();
2968-
} else if constexpr (std::is_same_v<T, TTtlEvictToExternalStorageAction>) {
2969-
proto.mutable_evict_to_external_storage()->set_storage_name(action.StorageName);
2970-
} else if constexpr (std::is_same_v<T, TTtlEvictToColumnFamilyAction>) {
2971-
proto.mutable_evict_to_column_family()->set_storage_name(action.FamilyName);
2972-
}
2973-
};
2974-
std::visit(std::move(actionVisitor), Action_);
2962+
std::visit(TOverloaded{
2963+
[&proto](const TTtlDeleteAction&) { proto.mutable_delete_(); },
2964+
[&proto](const TTtlEvictToExternalStorageAction& action) {
2965+
proto.mutable_evict_to_external_storage()->set_storage_name(action.StorageName);
2966+
},
2967+
[](const std::monostate) {},
2968+
},
2969+
Action_);
29752970
}
29762971

29772972
TDuration TTtlTierSettings::GetEvictionDelay() const {

ydb/public/sdk/cpp/client/ydb_table/table.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -428,10 +428,6 @@ struct TTtlEvictToExternalStorageAction {
428428
TString StorageName;
429429
};
430430

431-
struct TTtlEvictToColumnFamilyAction {
432-
TString FamilyName;
433-
};
434-
435431
class TTtlTierSettings {
436432
public:
437433
using TAction = std::variant<

0 commit comments

Comments
 (0)