Skip to content

Commit 2a4923c

Browse files
committed
Fixed unit tests
1 parent fe27bca commit 2a4923c

File tree

6 files changed

+17
-5
lines changed

6 files changed

+17
-5
lines changed

ydb/core/kqp/proxy_service/kqp_proxy_databases_cache.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,11 @@ class TDatabaseSubscriberActor : public TActor<TDatabaseSubscriberActor> {
127127
if (status == Ydb::StatusIds::SUCCESS || status == Ydb::StatusIds::UNSUPPORTED) {
128128
Send(subscriber, new TEvKqp::TEvUpdateDatabaseInfo(database, databaseState.DatabaseId, databaseState.Serverless));
129129
} else {
130-
Send(subscriber, new TEvKqp::TEvUpdateDatabaseInfo(database, status, std::move(issues)));
130+
NYql::TIssue rootIssue(TStringBuilder() << "Failed to describe database" << database);
131+
for (const auto& issue : issues) {
132+
rootIssue.AddSubIssue(MakeIntrusive<NYql::TIssue>(issue));
133+
}
134+
Send(subscriber, new TEvKqp::TEvUpdateDatabaseInfo(database, status, {rootIssue}));
131135
}
132136
}
133137

ydb/core/kqp/proxy_service/kqp_proxy_service.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -646,6 +646,8 @@ class TKqpProxyService : public TActorBootstrapped<TKqpProxyService> {
646646
return;
647647
}
648648

649+
Cerr << "------------------------------- DatabaseId: " << ev->Get()->GetDatabaseId() << "\n";
650+
649651
const TString& database = ev->Get()->GetDatabase();
650652
const TString& traceId = ev->Get()->GetTraceId();
651653
const auto queryType = ev->Get()->GetType();

ydb/core/kqp/proxy_service/kqp_proxy_service_impl.h

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -662,7 +662,7 @@ class TDatabasesCache {
662662
return true;
663663
}
664664

665-
const auto& database = event->Get()->GetDatabase();
665+
const auto& database = CanonizePath(event->Get()->GetDatabase());
666666
auto& databaseInfo = DatabasesCache[database];
667667
if (databaseInfo.DatabaseId) {
668668
event->Get()->SetDatabaseId(databaseInfo.DatabaseId);
@@ -682,7 +682,11 @@ class TDatabasesCache {
682682
}
683683

684684
void UpdateDatabaseInfo(TEvKqp::TEvUpdateDatabaseInfo::TPtr& event, TActorContext actorContext) {
685-
auto it = DatabasesCache.find(event->Get()->Database);
685+
const auto& database = event->Get()->Database;
686+
auto it = DatabasesCache.find(database);
687+
if (it == DatabasesCache.end()) {
688+
it = DatabasesCache.insert({database, TDatabaseInfo{}}).first;
689+
}
686690
it->second.DatabaseId = event->Get()->DatabaseId;
687691

688692
bool success = event->Get()->Status == Ydb::StatusIds::SUCCESS;

ydb/core/kqp/proxy_service/ut/ya.make

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ PEERDIR(
1313
ydb/core/kqp/run_script_actor
1414
ydb/core/kqp/proxy_service
1515
ydb/core/kqp/ut/common
16+
ydb/core/kqp/workload_service/ut/common
1617
ydb/library/yql/sql/pg_dummy
1718
ydb/public/sdk/cpp/client/ydb_query
1819
ydb/public/sdk/cpp/client/ydb_driver

ydb/core/kqp/workload_service/ut/kqp_workload_service_ut.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -635,7 +635,7 @@ Y_UNIT_TEST_SUITE(ResourcePoolClassifiersDdl) {
635635
}
636636

637637
void WaitForFail(TIntrusivePtr<IYdbSetup> ydb, const TQueryRunnerSettings& settings, const TString& poolId) {
638-
ydb->WaitFor(TDuration::Seconds(5), "Resource pool classifier fail", [ydb, settings, poolId](TString& errorString) {
638+
ydb->WaitFor(TDuration::Seconds(10), "Resource pool classifier fail", [ydb, settings, poolId](TString& errorString) {
639639
auto result = ydb->ExecuteQuery(TSampleQueries::TSelect42::Query, settings);
640640

641641
errorString = result.GetIssues().ToOneLineString();
@@ -644,7 +644,7 @@ Y_UNIT_TEST_SUITE(ResourcePoolClassifiersDdl) {
644644
}
645645

646646
void WaitForSuccess(TIntrusivePtr<IYdbSetup> ydb, const TQueryRunnerSettings& settings) {
647-
ydb->WaitFor(TDuration::Seconds(5), "Resource pool classifier success", [ydb, settings](TString& errorString) {
647+
ydb->WaitFor(TDuration::Seconds(10), "Resource pool classifier success", [ydb, settings](TString& errorString) {
648648
auto result = ydb->ExecuteQuery(TSampleQueries::TSelect42::Query, settings);
649649

650650
errorString = result.GetIssues().ToOneLineString();

ydb/tests/tools/kqprun/configuration/app_config.conf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ FeatureFlags {
5353
EnableScriptExecutionOperations: true
5454
EnableExternalSourceSchemaInference: true
5555
EnableTempTables: true
56+
EnableResourcePools: false
5657
}
5758

5859
KQPConfig {

0 commit comments

Comments
 (0)