improve errors for source-only functions

Author: nepal

ydb/library/yql/sql/v1/builtin.cpp

@@ -1838,7 +1838,7 @@ class TTableRow final : public INode {
 
     bool DoInit(TContext& ctx, ISource* src) override {
         if (!src || src->IsFake()) {
-            ctx.Error(Pos) << "TableRow requires data source";
+            ctx.Error(Pos) << TStringBuilder() << (Join ? "Join" : "") << "TableRow requires data source";
             return false;
         }
 

ydb/library/yql/sql/v1/node.cpp

@@ -967,7 +967,7 @@ TCallDirectRow::TCallDirectRow(TPosition pos, const TString& opName, const TVect
 {}
 
 bool TCallDirectRow::DoInit(TContext& ctx, ISource* src) {
-    if (!src) {
+    if (!src || (ctx.CompactNamedExprs && src->IsFake())) {
         ctx.Error(Pos) << "Unable to use function: " << OpName << " without source";
         return false;
     }

ydb/library/yql/sql/v1/sql_ut.cpp

@@ -6758,11 +6758,24 @@ Y_UNIT_TEST_SUITE(TViewSyntaxTest) {
 }
 
 Y_UNIT_TEST_SUITE(CompactNamedExprs) {
-    Y_UNIT_TEST(TableRowInWrongContext) {
-        ExpectFailWithError(
-            "pragma CompactNamedExprs;\n"
-            "$foo = TableRow();\n"
-            "select $foo from plato.Input;\n",
-            "<main>:2:8: Error: TableRow requires data source\n");
+    Y_UNIT_TEST(SourceCallablesInWrongContext) {
+        TString query = R"(
+            pragma CompactNamedExprs;
+            $foo = %s();
+            select $foo from plato.Input;
+        )";
+
+        THashMap<TString, TString> errs = {
+            {"TableRow", "<main>:3:20: Error: TableRow requires data source\n"},
+            {"JoinTableRow", "<main>:3:20: Error: JoinTableRow requires data source\n"},
+            {"TableRecordIndex", "<main>:3:20: Error: Unable to use function: TableRecord without source\n"},
+            {"TablePath", "<main>:3:20: Error: Unable to use function: TablePath without source\n"},
+            {"SystemMetadata", "<main>:3:20: Error: Unable to use function: SystemMetadata without source\n"},
+        };
+
+        for (TString callable : { "TableRow", "JoinTableRow", "TableRecordIndex", "TablePath", "SystemMetadata"}) {
+            auto req = Sprintf(query.c_str(), callable.c_str());
+            ExpectFailWithError(req, errs[callable]);
+        }
     }
 }