Skip to content

Commit 20f0d5b

Browse files
authored
Merge c268df0 into 78fee80
2 parents 78fee80 + c268df0 commit 20f0d5b

File tree

3 files changed

+14
-4
lines changed

3 files changed

+14
-4
lines changed

ydb/core/fq/libs/row_dispatcher/format_handler/format_handler.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ namespace {
1717
class TTopicFormatHandler : public NActors::TActor<TTopicFormatHandler>, public ITopicFormatHandler, public TTypeParser {
1818
using TBase = NActors::TActor<TTopicFormatHandler>;
1919

20+
static constexpr char ActorName[] = "FQ_ROW_DISPATCHER_FORMAT_HANDLER";
21+
2022
struct TCounters {
2123
TCountersDesc Desc;
2224

ydb/core/fq/libs/row_dispatcher/row_dispatcher.cpp

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,11 +61,15 @@ struct TUserPoolMetrics {
6161
auto microsecGroup = execpoolGroup->GetSubgroup("sensor", "ElapsedMicrosecByActivity");
6262
Session = microsecGroup->GetNamedCounter("activity", "FQ_ROW_DISPATCHER_SESSION", true);
6363
RowDispatcher = microsecGroup->GetNamedCounter("activity", "FQ_ROW_DISPATCHER", true);
64-
Compiler = microsecGroup->GetNamedCounter("activity", "FQ_ROW_DISPATCHER_COMPILER", true);
64+
CompilerActor = microsecGroup->GetNamedCounter("activity", "FQ_ROW_DISPATCHER_COMPILE_ACTOR", true);
65+
CompilerService = microsecGroup->GetNamedCounter("activity", "FQ_ROW_DISPATCHER_COMPILE_SERVICE", true);
66+
FormatHandler = microsecGroup->GetNamedCounter("activity", "FQ_ROW_DISPATCHER_FORMAT_HANDLER", true);
6567
}
6668
::NMonitoring::TDynamicCounters::TCounterPtr Session;
6769
::NMonitoring::TDynamicCounters::TCounterPtr RowDispatcher;
68-
::NMonitoring::TDynamicCounters::TCounterPtr Compiler;
70+
::NMonitoring::TDynamicCounters::TCounterPtr CompilerActor;
71+
::NMonitoring::TDynamicCounters::TCounterPtr CompilerService;
72+
::NMonitoring::TDynamicCounters::TCounterPtr FormatHandler;
6973
};
7074

7175
struct TEvPrivate {
@@ -1145,7 +1149,9 @@ void TRowDispatcher::UpdateCpuTime() {
11451149
}
11461150
auto currentCpuTime = UserPoolMetrics.Session->Val()
11471151
+ UserPoolMetrics.RowDispatcher->Val()
1148-
+ UserPoolMetrics.Compiler->Val();
1152+
+ UserPoolMetrics.CompilerActor->Val()
1153+
+ UserPoolMetrics.CompilerService->Val()
1154+
+ UserPoolMetrics.FormatHandler->Val();
11491155
auto diff = (currentCpuTime - LastCpuTime) / Consumers.size();
11501156
for (auto& [actorId, consumer] : Consumers) {
11511157
consumer->CpuMicrosec += diff;

ydb/tests/fq/yds/test_row_dispatcher.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,13 @@
2121
import ydb.public.api.protos.draft.fq_pb2 as fq
2222

2323
YDS_CONNECTION = "yds"
24+
COMPUTE_NODE_COUNT=3
2425

2526

2627
@pytest.fixture
2728
def kikimr(request):
2829
kikimr_conf = StreamingOverKikimrConfig(
29-
cloud_mode=True, node_count={"/cp": TenantConfig(1), "/compute": TenantConfig(3)}
30+
cloud_mode=True, node_count={"/cp": TenantConfig(1), "/compute": TenantConfig(COMPUTE_NODE_COUNT)}
3031
)
3132
kikimr = StreamingOverKikimr(kikimr_conf)
3233
kikimr.compute_plane.fq_config['row_dispatcher']['enabled'] = True
@@ -957,6 +958,7 @@ def test_sensors(self, kikimr, client):
957958

958959
wait_actor_count(kikimr, "DQ_PQ_READ_ACTOR", 1)
959960
wait_actor_count(kikimr, "FQ_ROW_DISPATCHER_SESSION", 1)
961+
wait_actor_count(kikimr, "FQ_ROW_DISPATCHER_COMPILE_SERVICE", COMPUTE_NODE_COUNT)
960962
wait_row_dispatcher_sensor_value(kikimr, "ClientsCount", 1)
961963
wait_row_dispatcher_sensor_value(kikimr, "RowsSent", 1, exact_match=False)
962964
wait_row_dispatcher_sensor_value(kikimr, "IncomingRequests", 1, exact_match=False)

0 commit comments

Comments
 (0)