Merge f830faf into 5916f32

maximyurchuk · web-flow · commit 15b2937a1b66 · 2024-08-01T10:11:10.000Z
diff --git a/.github/actions/test_ya/action.yml b/.github/actions/test_ya/action.yml
@@ -192,6 +192,8 @@ runs:
           params+=(-A)
         fi
 
+        params+=(-k)
+
         params+=(
           --stat -DCONSISTENT_DEBUG --no-dir-outputs
           --test-failure-code 0 --build-all 
diff --git a/build/internal/ya.conf b/build/internal/ya.conf
@@ -22,3 +22,4 @@ USE_ICONV = "static"
 USE_IDN = "static"
 APPLE_SDK_LOCAL = "yes"
 CFLAGS = "-fno-omit-frame-pointer"
+FIX_UNUSED_PARAMETR_PLS = "1"  # 31 jul 2024. Transitional flag for protobuf fix, DTCC-2275
diff --git a/ydb/core/blobstorage/pdisk/blobstorage_pdisk_impl_metadata.cpp b/ydb/core/blobstorage/pdisk/blobstorage_pdisk_impl_metadata.cpp
@@ -70,7 +70,7 @@ namespace NKikimr::NPDisk {
                 Release(actorSystem);
             }
 
-            void Release(TActorSystem *actorSystem) override {
+            void Release(TActorSystem * /*actorSystem*/) override {
                 delete this;
             }
         };
diff --git a/ydb/core/config/tools/protobuf_plugin/main.cpp b/ydb/core/config/tools/protobuf_plugin/main.cpp
@@ -44,8 +44,7 @@ class TMessageGenerator
         return name;
     }
 
-    TString ConstructFullFieldPath(const TDeque<const FieldDescriptor*>& fieldPath, const FieldDescriptor* field) const {
-
+    TString ConstructFullFieldPath(const TDeque<const FieldDescriptor*>& fieldPath, const FieldDescriptor* /*field*/) const {
         TVector<TString> path;
         path.push_back("");
         for (size_t i = 1; i < fieldPath.size(); ++i) {
diff --git a/ydb/core/formats/arrow/accessor/composite/accessor.h b/ydb/core/formats/arrow/accessor/composite/accessor.h
@@ -21,7 +21,7 @@ class TCompositeChunkedArray: public NArrow::NAccessor::IChunkedArray {
         return {};
     }
 
-    virtual std::shared_ptr<arrow::Scalar> DoGetScalar(const ui32 index) const override {
+    virtual std::shared_ptr<arrow::Scalar> DoGetScalar(const ui32 /*index*/) const override {
         AFL_VERIFY(false)("problem", "cannot use method");
         return nullptr;
     }
diff --git a/ydb/core/formats/arrow/accessor/composite_serial/accessor.h b/ydb/core/formats/arrow/accessor/composite_serial/accessor.h
@@ -60,7 +60,7 @@ class TDeserializeChunkedArray: public NArrow::NAccessor::IChunkedArray {
         return {};
     }
 
-    virtual std::shared_ptr<arrow::Scalar> DoGetScalar(const ui32 index) const override {
+    virtual std::shared_ptr<arrow::Scalar> DoGetScalar(const ui32 /*index*/) const override {
         AFL_VERIFY(false)("problem", "cannot use method");
         return nullptr;
     }
diff --git a/ydb/core/formats/arrow/accessor/plain/accessor.h b/ydb/core/formats/arrow/accessor/plain/accessor.h
@@ -12,7 +12,7 @@ class TTrivialArray: public IChunkedArray {
 protected:
     virtual std::optional<ui64> DoGetRawSize() const override;
 
-    virtual TLocalDataAddress DoGetLocalData(const std::optional<TCommonChunkAddress>& /*chunkCurrent*/, const ui64 position) const override {
+    virtual TLocalDataAddress DoGetLocalData(const std::optional<TCommonChunkAddress>& /*chunkCurrent*/, const ui64 /*position*/) const override {
         return TLocalDataAddress(Array, 0, 0);
     }
     virtual std::shared_ptr<arrow::ChunkedArray> DoGetChunkedArray() const override {
diff --git a/ydb/core/formats/arrow/accessor/sparsed/accessor.h b/ydb/core/formats/arrow/accessor/sparsed/accessor.h
@@ -115,7 +115,7 @@ class TSparsedArray: public IChunkedArray {
         return bytes;
     }
 
-    TSparsedArray(std::vector<TSparsedArrayChunk>&& data, const std::shared_ptr<arrow::Scalar>& defaultValue,
+    TSparsedArray(std::vector<TSparsedArrayChunk>&& data, const std::shared_ptr<arrow::Scalar>& /*defaultValue*/,
         const std::shared_ptr<arrow::DataType>& type, const ui32 recordsCount)
         : TBase(recordsCount, EType::SparsedArray, type)
         , Records(std::move(data)) {
diff --git a/ydb/core/formats/arrow/accessor/sparsed/constructor.cpp b/ydb/core/formats/arrow/accessor/sparsed/constructor.cpp
@@ -27,7 +27,7 @@ NKikimrArrowAccessorProto::TConstructor TConstructor::DoSerializeToProto() const
     return result;
 }
 
-bool TConstructor::DoDeserializeFromProto(const NKikimrArrowAccessorProto::TConstructor& proto) {
+bool TConstructor::DoDeserializeFromProto(const NKikimrArrowAccessorProto::TConstructor& /*proto*/) {
     return true;
 }
 
diff --git a/ydb/core/formats/arrow/reader/position.h b/ydb/core/formats/arrow/reader/position.h
@@ -97,7 +97,7 @@ class TSortableScanData {
         return PositionAddress[colIdx].GetAddress().GetLocalIndex(pos);
     }
 
-    std::shared_ptr<TSortableScanData> BuildCopy(const ui64 position) const {
+    std::shared_ptr<TSortableScanData> BuildCopy(const ui64 /*position*/) const {
         return std::make_shared<TSortableScanData>(*this);
     }
 
diff --git a/ydb/core/grpc_services/rpc_alter_table.cpp b/ydb/core/grpc_services/rpc_alter_table.cpp
@@ -228,7 +228,7 @@ class TAlterTableRPC : public TRpcSchemeRequestActor<TAlterTableRPC, TEvAlterTab
         Send(schemeCache, ev);
     }
 
-    void Navigate(const TTableId& pathId, const TActorContext& ctx) {
+    void Navigate(const TTableId& pathId, const TActorContext& /*ctx*/) {
         DatabaseName = Request_->GetDatabaseName()
             .GetOrElse(DatabaseFromDomain(AppData()));
 
diff --git a/ydb/core/statistics/aggregator/ut/ut_traverse_columnshard.cpp b/ydb/core/statistics/aggregator/ut/ut_traverse_columnshard.cpp
@@ -89,7 +89,7 @@ Y_UNIT_TEST_SUITE(TraverseColumnShard) {
         auto sender = runtime.AllocateEdgeActor();
         bool observerFirstExec = true;
         auto observer = runtime.AddObserver<TEvHive::TEvRequestTabletDistribution>(
-            [&](TEvHive::TEvRequestTabletDistribution::TPtr& ev)
+            [&](TEvHive::TEvRequestTabletDistribution::TPtr& /*ev*/)
         {
             if (observerFirstExec) {
                 observerFirstExec = false;
diff --git a/ydb/core/tx/columnshard/engines/changes/indexation.cpp b/ydb/core/tx/columnshard/engines/changes/indexation.cpp
@@ -53,7 +53,7 @@ class TBatchInfo {
     YDB_READONLY_DEF(std::shared_ptr<NArrow::TGeneralContainer>, Batch);
 
 public:
-    TBatchInfo(const std::shared_ptr<NArrow::TGeneralContainer>& batch, const NEvWrite::EModificationType modificationType)
+    TBatchInfo(const std::shared_ptr<NArrow::TGeneralContainer>& batch, const NEvWrite::EModificationType /*modificationType*/)
         : Batch(batch) {
     }
 };
diff --git a/ydb/core/tx/columnshard/engines/scheme/abstract/index_info.h b/ydb/core/tx/columnshard/engines/scheme/abstract/index_info.h
@@ -165,7 +165,7 @@ class IIndexInfo {
                fieldId == (ui32)ESpecialColumn::DELETE_FLAG;
     }
 
-    static bool IsNullableVerified(const ui32 fieldId) {
+    static bool IsNullableVerified(const ui32 /*fieldId*/) {
         return false;
     }
 
diff --git a/ydb/core/tx/schemeshard/schemeshard__operation_create_restore_incremental_backup.cpp b/ydb/core/tx/schemeshard/schemeshard__operation_create_restore_incremental_backup.cpp
@@ -16,7 +16,7 @@ const char* IB_RESTORE_CDC_STREAM_NAME = "__ib_restore_stream";
 
 namespace NKikimr::NSchemeShard {
 
-void DoCreateLock(const TOperationId opId, const TPath& workingDirPath, const TPath& tablePath, bool allowIndexImplLock,
+void DoCreateLock(const TOperationId opId, const TPath& workingDirPath, const TPath& tablePath, bool /*allowIndexImplLock*/,
     TVector<ISubOperation::TPtr>& result)
 {
     auto outTx = TransactionTemplate(workingDirPath.PathString(),
diff --git a/ydb/library/yql/minikql/comp_nodes/mkql_wide_combine.cpp b/ydb/library/yql/minikql/comp_nodes/mkql_wide_combine.cpp
@@ -132,7 +132,7 @@ struct TCombinerNodes {
         }
     }
 
-    void ConsumeRawData(TComputationContext& ctx, NUdf::TUnboxedValue* keys, NUdf::TUnboxedValue** from, NUdf::TUnboxedValue* to) const {
+    void ConsumeRawData(TComputationContext& /*ctx*/, NUdf::TUnboxedValue* keys, NUdf::TUnboxedValue** from, NUdf::TUnboxedValue* to) const {
         std::fill_n(keys, KeyResultNodes.size(), NUdf::TUnboxedValuePod());
         for (ui32 i = 0U; i < ItemNodes.size(); ++i) {
             if (from[i] && IsInputItemNodeUsed(i)) {
diff --git a/ydb/library/yql/providers/yt/lib/res_pull/res_or_pull.cpp b/ydb/library/yql/providers/yt/lib/res_pull/res_or_pull.cpp
@@ -185,7 +185,7 @@ void TSkiffExecuteResOrPull::WriteValue(const NUdf::TUnboxedValue& value, TType*
     }
 }
 
-bool TSkiffExecuteResOrPull::WriteNext(TMkqlIOCache& specsCache, const NYT::TNode& rec, ui32 tableIndex) {
+bool TSkiffExecuteResOrPull::WriteNext(TMkqlIOCache& specsCache, const NYT::TNode& rec, ui32 /*tableIndex*/) {
     if (!HasCapacity()) {
         Truncated = true;
         return false;
diff --git a/ydb/library/yql/sql/v1/select.cpp b/ydb/library/yql/sql/v1/select.cpp
@@ -287,7 +287,7 @@ class TNodeSource: public ISource {
         return ISource::DoInit(ctx, src);
     }
 
-    TNodePtr Build(TContext& ctx) final  {
+    TNodePtr Build(TContext& /*ctx*/) final  {
         auto nodeAst = AstNode(Node);
         if (WrapToList) {
             nodeAst = Y("ToList", nodeAst);

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ namespace NKikimr::NPDisk {`
`70`	`70`	`Release(actorSystem);`
`71`	`71`	`}`
`72`	`72`
`73`		`- void Release(TActorSystem *actorSystem) override {`
	`73`	`+ void Release(TActorSystem * /actorSystem/) override {`
`74`	`74`	`delete this;`
`75`	`75`	`}`
`76`	`76`	`};`
Original file line number	Diff line number	Diff line change
`@@ -44,8 +44,7 @@ class TMessageGenerator`
`44`	`44`	`return name;`
`45`	`45`	`}`
`46`	`46`
`47`		`- TString ConstructFullFieldPath(const TDeque<const FieldDescriptor>& fieldPath, const FieldDescriptor field) const {`
`48`		`-`
	`47`	`+ TString ConstructFullFieldPath(const TDeque<const FieldDescriptor>& fieldPath, const FieldDescriptor /field/) const {`
`49`	`48`	`TVector<TString> path;`
`50`	`49`	`path.push_back("");`
`51`	`50`	`for (size_t i = 1; i < fieldPath.size(); ++i) {`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ class TCompositeChunkedArray: public NArrow::NAccessor::IChunkedArray {`
`21`	`21`	`return {};`
`22`	`22`	`}`
`23`	`23`
`24`		`- virtual std::shared_ptr<arrow::Scalar> DoGetScalar(const ui32 index) const override {`
	`24`	`+ virtual std::shared_ptr<arrow::Scalar> DoGetScalar(const ui32 /index/) const override {`
`25`	`25`	`AFL_VERIFY(false)("problem", "cannot use method");`
`26`	`26`	`return nullptr;`
`27`	`27`	`}`
Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ class TDeserializeChunkedArray: public NArrow::NAccessor::IChunkedArray {`
`60`	`60`	`return {};`
`61`	`61`	`}`
`62`	`62`
`63`		`- virtual std::shared_ptr<arrow::Scalar> DoGetScalar(const ui32 index) const override {`
	`63`	`+ virtual std::shared_ptr<arrow::Scalar> DoGetScalar(const ui32 /index/) const override {`
`64`	`64`	`AFL_VERIFY(false)("problem", "cannot use method");`
`65`	`65`	`return nullptr;`
`66`	`66`	`}`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ class TTrivialArray: public IChunkedArray {`
`12`	`12`	`protected:`
`13`	`13`	`virtual std::optional<ui64> DoGetRawSize() const override;`
`14`	`14`
`15`		`- virtual TLocalDataAddress DoGetLocalData(const std::optional<TCommonChunkAddress>& /chunkCurrent/, const ui64 position) const override {`
	`15`	`+ virtual TLocalDataAddress DoGetLocalData(const std::optional<TCommonChunkAddress>& /chunkCurrent/, const ui64 /position/) const override {`
`16`	`16`	`return TLocalDataAddress(Array, 0, 0);`
`17`	`17`	`}`
`18`	`18`	`virtual std::shared_ptr<arrow::ChunkedArray> DoGetChunkedArray() const override {`
Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,7 @@ class TSparsedArray: public IChunkedArray {`
`115`	`115`	`return bytes;`
`116`	`116`	`}`
`117`	`117`
`118`		`- TSparsedArray(std::vector<TSparsedArrayChunk>&& data, const std::shared_ptr<arrow::Scalar>& defaultValue,`
	`118`	`+ TSparsedArray(std::vector<TSparsedArrayChunk>&& data, const std::shared_ptr<arrow::Scalar>& /defaultValue/,`
`119`	`119`	`const std::shared_ptr<arrow::DataType>& type, const ui32 recordsCount)`
`120`	`120`	`: TBase(recordsCount, EType::SparsedArray, type)`
`121`	`121`	`, Records(std::move(data)) {`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ NKikimrArrowAccessorProto::TConstructor TConstructor::DoSerializeToProto() const`
`27`	`27`	`return result;`
`28`	`28`	`}`
`29`	`29`
`30`		`-bool TConstructor::DoDeserializeFromProto(const NKikimrArrowAccessorProto::TConstructor& proto) {`
	`30`	`+bool TConstructor::DoDeserializeFromProto(const NKikimrArrowAccessorProto::TConstructor& /proto/) {`
`31`	`31`	`return true;`
`32`	`32`	`}`
`33`	`33`
Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ class TSortableScanData {`
`97`	`97`	`return PositionAddress[colIdx].GetAddress().GetLocalIndex(pos);`
`98`	`98`	`}`
`99`	`99`
`100`		`- std::shared_ptr<TSortableScanData> BuildCopy(const ui64 position) const {`
	`100`	`+ std::shared_ptr<TSortableScanData> BuildCopy(const ui64 /position/) const {`
`101`	`101`	`return std::make_shared<TSortableScanData>(*this);`
`102`	`102`	`}`
`103`	`103`
Original file line number	Diff line number	Diff line change
`@@ -228,7 +228,7 @@ class TAlterTableRPC : public TRpcSchemeRequestActor<TAlterTableRPC, TEvAlterTab`
`228`	`228`	`Send(schemeCache, ev);`
`229`	`229`	`}`
`230`	`230`
`231`		`- void Navigate(const TTableId& pathId, const TActorContext& ctx) {`
	`231`	`+ void Navigate(const TTableId& pathId, const TActorContext& /ctx/) {`
`232`	`232`	`DatabaseName = Request_->GetDatabaseName()`
`233`	`233`	`.GetOrElse(DatabaseFromDomain(AppData()));`
`234`	`234`
Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ Y_UNIT_TEST_SUITE(TraverseColumnShard) {`
`89`	`89`	`auto sender = runtime.AllocateEdgeActor();`
`90`	`90`	`bool observerFirstExec = true;`
`91`	`91`	`auto observer = runtime.AddObserver<TEvHive::TEvRequestTabletDistribution>(`
`92`		`- [&](TEvHive::TEvRequestTabletDistribution::TPtr& ev)`
	`92`	`+ [&](TEvHive::TEvRequestTabletDistribution::TPtr& /ev/)`
`93`	`93`	`{`
`94`	`94`	`if (observerFirstExec) {`
`95`	`95`	`observerFirstExec = false;`