Skip to content

Commit 122c997

Browse files
json_query transaction mode
1 parent 43d5e45 commit 122c997

File tree

1 file changed

+24
-2
lines changed

1 file changed

+24
-2
lines changed

ydb/core/viewer/json_query.h

Lines changed: 24 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ class TJsonQuery : public TViewerPipeClient<TJsonQuery> {
3939
TString Stats;
4040
TString Syntax;
4141
TString QueryId;
42+
TString TransactionMode;
4243
bool Direct = false;
4344
bool IsBase64Encode = true;
4445

@@ -82,6 +83,7 @@ class TJsonQuery : public TViewerPipeClient<TJsonQuery> {
8283
Schema = StringToSchemaType(schemaStr);
8384
Syntax = params.Get("syntax");
8485
QueryId = params.Get("query_id");
86+
TransactionMode = params.Get("transaction_mode");
8587
Direct = FromStringWithDefault<bool>(params.Get("direct"), Direct);
8688
IsBase64Encode = FromStringWithDefault<bool>(params.Get("base64"), true);
8789
}
@@ -97,6 +99,7 @@ class TJsonQuery : public TViewerPipeClient<TJsonQuery> {
9799
Action = Action.empty() ? requestData["action"].GetStringSafe({}) : Action;
98100
Syntax = Syntax.empty() ? requestData["syntax"].GetStringSafe({}) : Syntax;
99101
QueryId = QueryId.empty() ? requestData["query_id"].GetStringSafe({}) : QueryId;
102+
TransactionMode = TransactionMode.empty() ? requestData["transaction_mode"].GetStringSafe({}) : TransactionMode;
100103
}
101104
return success;
102105
}
@@ -243,9 +246,17 @@ class TJsonQuery : public TViewerPipeClient<TJsonQuery> {
243246
} else if (Action == "execute-data") {
244247
request.SetAction(NKikimrKqp::QUERY_ACTION_EXECUTE);
245248
request.SetType(NKikimrKqp::QUERY_TYPE_SQL_DML);
246-
request.mutable_txcontrol()->mutable_begin_tx()->mutable_serializable_read_write();
247-
request.mutable_txcontrol()->set_commit_tx(true);
248249
request.SetKeepSession(false);
250+
if (TransactionMode == "online-read-only") {
251+
request.mutable_txcontrol()->mutable_begin_tx()->mutable_online_read_only();
252+
} else if (TransactionMode == "stale-read-only") {
253+
request.mutable_txcontrol()->mutable_begin_tx()->mutable_stale_read_only();
254+
} else if (TransactionMode == "snapshot-read-only") {
255+
request.mutable_txcontrol()->mutable_begin_tx()->mutable_snapshot_read_only();
256+
} else {
257+
request.mutable_txcontrol()->mutable_begin_tx()->mutable_serializable_read_write();
258+
request.mutable_txcontrol()->set_commit_tx(true);
259+
}
249260
} else if (Action == "explain" || Action == "explain-ast" || Action == "explain-data") {
250261
request.SetAction(NKikimrKqp::QUERY_ACTION_EXPLAIN);
251262
request.SetType(NKikimrKqp::QUERY_TYPE_SQL_DML);
@@ -662,6 +673,17 @@ YAML::Node TJsonRequestSwagger<TJsonQuery>::GetSwagger() {
662673
type: string
663674
enum: [profile, full]
664675
required: false
676+
- name: transaction_mode
677+
in: query
678+
description: >
679+
transaction mode:
680+
* `serializable-read-write`
681+
* `online-read-only`
682+
* `stale-read-only`
683+
* `snapshot-read-only`
684+
type: string
685+
enum: [serializable-read-write, online-read-only, stale-read-only, snapshot-read-only]
686+
required: false
665687
- name: direct
666688
in: query
667689
description: force processing query on current node

0 commit comments

Comments
 (0)