Merge 0d9af5c into d4e8297

Author: vlad-gogov

ydb/core/kqp/ut/olap/compression_ut.cpp

@@ -0,0 +1,42 @@
+#include "helpers/typed_local.h"
+
+#include <ydb/core/kqp/ut/common/columnshard.h>
+
+namespace NKikimr::NKqp {
+
+Y_UNIT_TEST_SUITE(KqpOlapCompression) {
+    Y_UNIT_TEST(DisabledAlterCompression) {
+        TKikimrSettings settings = TKikimrSettings().SetWithSampleTables(false).SetEnableOlapCompression(false);
+        {
+            TKikimrRunner kikimr(settings);
+            TTypedLocalHelper helper("", kikimr, "olapTable", "olapStore");
+            helper.CreateTestOlapTable();
+            helper.FillPKOnly(0, 1);
+            helper.ExecuteSchemeQuery(
+                "ALTER OBJECT `/Root/olapStore/olapTable` (TYPE TABLE) SET (ACTION=ALTER_COLUMN, NAME=pk_int, "
+                "`SERIALIZER.CLASS_NAME`=`ARROW_SERIALIZER`, `COMPRESSION.TYPE`=`zstd`);", NYdb::EStatus::SCHEME_ERROR);
+            helper.ExecuteSchemeQuery(
+                "ALTER OBJECT `/Root/olapStore` (TYPE TABLESTORE) SET (ACTION=ALTER_COLUMN, NAME=pk_int, "
+                "`SERIALIZER.CLASS_NAME`=`ARROW_SERIALIZER`, `COMPRESSION.TYPE`=`zstd`);", NYdb::EStatus::PRECONDITION_FAILED);
+        }
+
+        {
+            TTestHelper helper(settings);
+            TVector<TTestHelper::TColumnSchema> schema = {
+                TTestHelper::TColumnSchema().SetName("pk_int").SetType(NScheme::NTypeIds::Uint64).SetNullable(false)
+            };
+
+            TTestHelper::TColumnTable table;
+            table.SetName("/Root/olapTable").SetPrimaryKey({ "pk_int" }).SetSharding({ "pk_int" }).SetSchema(schema);
+            helper.CreateTable(table);
+
+            auto alterResult = helper.GetSession()
+                                   .ExecuteSchemeQuery(
+                                       "ALTER OBJECT `/Root/olapTable` (TYPE TABLE) SET (ACTION=ALTER_COLUMN, "
+                                       "NAME=pk_int,`SERIALIZER.CLASS_NAME`=`ARROW_SERIALIZER`, `COMPRESSION.TYPE`=`zstd`);")
+                                   .GetValueSync();
+            UNIT_ASSERT_VALUES_EQUAL_C(alterResult.GetStatus(), NYdb::EStatus::SCHEME_ERROR, alterResult.GetIssues().ToString());
+        }
+    }
+}
+}

ydb/core/kqp/ut/olap/sys_view_ut.cpp

@@ -219,17 +219,6 @@ Y_UNIT_TEST_SUITE(KqpOlapSysView) {
         }
     }
 
-    Y_UNIT_TEST(DisabledAlterCompression) {
-        TKikimrSettings settings = TKikimrSettings().SetWithSampleTables(false).SetEnableOlapCompression(false);
-        TKikimrRunner kikimr(settings);
-        TTypedLocalHelper helper("", kikimr, "olapTable", "olapStore");
-        helper.CreateTestOlapTable();
-        helper.FillPKOnly(0, 1);
-        helper.ExecuteSchemeQuery(
-            "ALTER OBJECT `/Root/olapStore` (TYPE TABLESTORE) SET (ACTION=ALTER_COLUMN, NAME=pk_int, "
-            "`SERIALIZER.CLASS_NAME`=`ARROW_SERIALIZER`, `COMPRESSION.TYPE`=`zstd`);", NYdb::EStatus::PRECONDITION_FAILED);
-    }
-
     Y_UNIT_TEST(StatsSysViewBytesColumnActualization) {
         ui64 rawBytes1;
         ui64 bytes1;

ydb/core/kqp/ut/olap/ya.make

@@ -26,6 +26,7 @@ SRCS(
     sparsed_ut.cpp
     tiering_ut.cpp
     decimal_ut.cpp
+    compression_ut.cpp
 )
 
 PEERDIR(

ydb/core/kqp/ut/scheme/kqp_scheme_ut.cpp

@@ -8325,7 +8325,6 @@ Y_UNIT_TEST_SUITE(KqpOlapScheme) {
         testTable.SetName("/Root/ColumnTableTest").SetPrimaryKey({"id"}).SetSchema(schema);
         testHelper.CreateTable(testTable, EStatus::SCHEME_ERROR);
     }
-
 }
 
 Y_UNIT_TEST_SUITE(KqpOlapTypes) {
@@ -8555,6 +8554,7 @@ Y_UNIT_TEST_SUITE(KqpOlapTypes) {
             testHelper.BulkUpsert(testTable, tableInserter, Ydb::StatusIds::SCHEME_ERROR);
         }
     }
+    
 }
 
 } // namespace NKqp