Skip to content

Commit 0293b47

Browse files
authored
YQ-2068 remove unused ProgramBuilder for transformer (#2162)
1 parent 0c44dfe commit 0293b47

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

ydb/library/yql/dq/actors/compute/dq_compute_actor_async_io.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -234,6 +234,9 @@ struct IDqAsyncIoFactory : public TThrRefBase {
234234
IRandomProvider *const RandomProvider;
235235
};
236236

237+
//TODO (YQ-2068) temporary flag for changing interface
238+
#define Y_YQL_DQ_NO_PROGRAM_BUILDER_FOR_TRANSFORM
239+
237240
struct TInputTransformArguments {
238241
const NDqProto::TTaskInput& InputDesc;
239242
const ui64 InputIndex;
@@ -246,7 +249,6 @@ struct IDqAsyncIoFactory : public TThrRefBase {
246249
const NActors::TActorId& ComputeActorId;
247250
const NKikimr::NMiniKQL::TTypeEnvironment& TypeEnv;
248251
const NKikimr::NMiniKQL::THolderFactory& HolderFactory;
249-
NKikimr::NMiniKQL::TProgramBuilder& ProgramBuilder;
250252
std::shared_ptr<NKikimr::NMiniKQL::TScopedAlloc> Alloc;
251253
NWilson::TTraceId TraceId;
252254
};
@@ -263,7 +265,6 @@ struct IDqAsyncIoFactory : public TThrRefBase {
263265
const THashMap<TString, TString>& TaskParams;
264266
const NKikimr::NMiniKQL::TTypeEnvironment& TypeEnv;
265267
const NKikimr::NMiniKQL::THolderFactory& HolderFactory;
266-
NKikimr::NMiniKQL::TProgramBuilder& ProgramBuilder;
267268
};
268269

269270
// Creates source.

ydb/library/yql/dq/actors/compute/dq_compute_actor_impl.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -801,7 +801,6 @@ class TDqComputeActorBase : public NActors::TActorBootstrapped<TDerived>
801801

802802
struct TAsyncInputTransformHelper : TAsyncInputHelper {
803803
NUdf::TUnboxedValue InputBuffer;
804-
TMaybe<NKikimr::NMiniKQL::TProgramBuilder> ProgramBuilder;
805804

806805
using TAsyncInputHelper::TAsyncInputHelper;
807806
};
@@ -936,7 +935,6 @@ class TDqComputeActorBase : public NActors::TActorBootstrapped<TDerived>
936935

937936
struct TAsyncOutputTransformInfo : public TAsyncOutputInfoBase {
938937
IDqOutputConsumer::TPtr OutputBuffer;
939-
TMaybe<NKikimr::NMiniKQL::TProgramBuilder> ProgramBuilder;
940938
};
941939

942940
protected:
@@ -1281,7 +1279,6 @@ class TDqComputeActorBase : public NActors::TActorBootstrapped<TDerived>
12811279
this->RegisterWithSameMailbox(source.Actor);
12821280
}
12831281
for (auto& [inputIndex, transform] : InputTransformsMap) {
1284-
transform.ProgramBuilder.ConstructInPlace(typeEnv, *FunctionRegistry);
12851282
Y_ABORT_UNLESS(AsyncIoFactory);
12861283
const auto& inputDesc = Task.GetInputs(inputIndex);
12871284
CA_LOG_D("Create transform for input " << inputIndex << " " << inputDesc.ShortDebugString());
@@ -1299,7 +1296,6 @@ class TDqComputeActorBase : public NActors::TActorBootstrapped<TDerived>
12991296
.ComputeActorId = this->SelfId(),
13001297
.TypeEnv = typeEnv,
13011298
.HolderFactory = holderFactory,
1302-
.ProgramBuilder = *transform.ProgramBuilder,
13031299
.Alloc = Alloc,
13041300
.TraceId = ComputeActorSpan.GetTraceId()
13051301
});
@@ -1309,7 +1305,6 @@ class TDqComputeActorBase : public NActors::TActorBootstrapped<TDerived>
13091305
this->RegisterWithSameMailbox(transform.Actor);
13101306
}
13111307
for (auto& [outputIndex, transform] : OutputTransformsMap) {
1312-
transform.ProgramBuilder.ConstructInPlace(typeEnv, *FunctionRegistry);
13131308
Y_ABORT_UNLESS(AsyncIoFactory);
13141309
const auto& outputDesc = Task.GetOutputs(outputIndex);
13151310
CA_LOG_D("Create transform for output " << outputIndex << " " << outputDesc.ShortDebugString());
@@ -1326,7 +1321,6 @@ class TDqComputeActorBase : public NActors::TActorBootstrapped<TDerived>
13261321
.TaskParams = taskParams,
13271322
.TypeEnv = typeEnv,
13281323
.HolderFactory = holderFactory,
1329-
.ProgramBuilder = *transform.ProgramBuilder
13301324
});
13311325
} catch (const std::exception& ex) {
13321326
throw yexception() << "Failed to create output transform " << outputDesc.GetTransform().GetType() << ": " << ex.what();

0 commit comments

Comments
 (0)