Skip to content

Commit 005c7be

Browse files
committed
Fix comments
1 parent b85d308 commit 005c7be

File tree

4 files changed

+4
-11
lines changed

4 files changed

+4
-11
lines changed

ydb/core/kqp/gateway/kqp_metadata_loader.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -851,7 +851,7 @@ NThreading::TFuture<TTableMetadataResult> TKqpTableMetadataLoader::LoadTableMeta
851851
{
852852
auto externalDataSourceMetadata = result.GetValue();
853853
auto newMetadata = EnrichExternalTable(externalTableMetadata, externalDataSourceMetadata);
854-
promise.SetValue(std::move(externalTableMetadata));
854+
promise.SetValue(std::move(newMetadata));
855855
});
856856
break;
857857
}

ydb/core/kqp/provider/yql_kikimr_datasource.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,8 @@ void ExtractReadAttributes(THashMap<std::pair<TString, TString>, THashMap<TStrin
157157
void GatherReadAttributes(THashMap<std::pair<TString, TString>, THashMap<TString, TString>>& result, const TExprNode& node, TExprContext& ctx) {
158158
if (node.IsCallable(ReadName)) {
159159
return ExtractReadAttributes(result, node, ctx);
160-
} else if (node.IsCallable()) {
160+
}
161+
if (node.IsCallable()) {
161162
if (node.ChildrenSize() == 0) {
162163
return;
163164
}

ydb/core/kqp/provider/yql_kikimr_gateway.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -864,7 +864,7 @@ class IKikimrGateway : public TThrRefBase {
864864
return *this;
865865
}
866866

867-
NKikimr::NExternalSource::IExternalSourceFactory::TPtr ExternalSourceFactory = nullptr;
867+
NKikimr::NExternalSource::IExternalSourceFactory::TPtr ExternalSourceFactory;
868868
THashMap<TString, TString> Options;
869869
bool RequestStats_ = false;
870870
bool WithPrivateTables_ = false;

ydb/library/yql/providers/s3/provider/yql_s3_datasource_type_ann.cpp

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -707,14 +707,6 @@ class TS3DataSourceTypeAnnotationTransformer : public TVisitorTransformerBase {
707707
return true;
708708
}
709709

710-
if (name == "infer") {
711-
TStringBuf data;
712-
if (!ExtractSettingValue(setting.Tail(), "infer"sv, format, {}, ctx, data)) {
713-
return false;
714-
}
715-
return true;
716-
}
717-
718710
YQL_ENSURE(name == "projection"sv);
719711
haveProjection = true;
720712
if (!EnsureAtom(setting.Tail(), ctx)) {

0 commit comments

Comments
 (0)