add tests

Author: kobzonega

internal/controllers/database/controller_test.go

@@ -3,6 +3,7 @@ package database_test
 import (
 	"context"
 	"errors"
+	"fmt"
 	"path/filepath"
 	"strings"
 	"testing"
@@ -142,5 +143,61 @@ var _ = Describe("Database controller medium tests", func() {
 				}
 			}
 		})
+
+		By("Check annotation has been propagated to pods...")
+		foundDatabase := v1alpha1.Database{}
+		Expect(k8sClient.Get(ctx, types.NamespacedName{
+			Name:      testobjects.DatabaseName,
+			Namespace: testobjects.YdbNamespace,
+		}, &foundDatabase)).Should(Succeed())
+		nodeHost := fmt.Sprintf("%s.testing.k8s-c.yandex.net", testobjects.YdbNamespace)
+		foundDatabase.Annotations = make(map[string]string)
+		foundDatabase.Annotations[v1alpha1.AnnotationNodeHost] = nodeHost
+		Eventually(func() error {
+			return k8sClient.Update(ctx, &foundDatabase)
+		}, test.Timeout, test.Interval).ShouldNot(HaveOccurred())
+
+		Eventually(func() error {
+			databaseStatefulSet := appsv1.StatefulSet{}
+			foundStatefulSets := appsv1.StatefulSetList{}
+			Eventually(func() error {
+				err := k8sClient.List(ctx, &foundStatefulSets, client.InNamespace(
+					testobjects.YdbNamespace))
+				if err != nil {
+					return err
+				}
+				for idx, statefulSet := range foundStatefulSets.Items {
+					if statefulSet.Name == testobjects.DatabaseName {
+						databaseStatefulSet = foundStatefulSets.Items[idx]
+						return nil
+					}
+				}
+				return errors.New("failed to find StatefulSet")
+			}, test.Timeout, test.Interval).ShouldNot(HaveOccurred())
+
+			podAnnotations := databaseStatefulSet.Spec.Template.Annotations
+			val, exist := podAnnotations[v1alpha1.AnnotationNodeHost]
+			if !exist {
+				return fmt.Errorf("annotation %s does not exist on statefulset template", v1alpha1.AnnotationNodeHost)
+			}
+			if val != nodeHost {
+				return fmt.Errorf("annotation value %s does not equal with desired: %s", val, nodeHost)
+			}
+
+			podContainerArgs := databaseStatefulSet.Spec.Template.Spec.Containers[0].Args
+			var nodeHostArgValue string
+			for idx, arg := range podContainerArgs {
+				if arg == "--node-host" {
+					nodeHostArgValue = podContainerArgs[idx+1]
+				}
+			}
+
+			nodeHostArgDesired := fmt.Sprintf("%s.%s", "$(NODE_NAME)", nodeHost)
+			if nodeHostArgDesired != nodeHostArgValue {
+				return fmt.Errorf("arg value `--node-host` %s does not equal with desired %s", nodeHostArgValue, nodeHostArgDesired)
+			}
+
+			return nil
+		}, test.Timeout, test.Interval).ShouldNot(HaveOccurred())
 	})
 })

internal/controllers/storage/controller_test.go

@@ -4,7 +4,6 @@ import (
 	"context"
 	"fmt"
 	"path/filepath"
-	"strconv"
 	"strings"
 	"testing"
 
@@ -13,15 +12,12 @@ import (
 	appsv1 "k8s.io/api/apps/v1"
 	corev1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	"k8s.io/apimachinery/pkg/types"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/manager"
 
 	"github.com/ydb-platform/ydb-kubernetes-operator/api/v1alpha1"
 	testobjects "github.com/ydb-platform/ydb-kubernetes-operator/e2e/tests/test-objects"
-	"github.com/ydb-platform/ydb-kubernetes-operator/internal/annotations"
 	"github.com/ydb-platform/ydb-kubernetes-operator/internal/controllers/storage"
-	"github.com/ydb-platform/ydb-kubernetes-operator/internal/labels"
 	"github.com/ydb-platform/ydb-kubernetes-operator/internal/test"
 )
 
@@ -57,10 +53,6 @@ var _ = Describe("Storage controller medium tests", func() {
 		Expect(k8sClient.Create(ctx, &namespace)).Should(Succeed())
 	})
 
-	AfterEach(func() {
-		Expect(k8sClient.Delete(ctx, &namespace)).Should(Succeed())
-	})
-
 	It("Checking field propagation to objects", func() {
 		storageSample := testobjects.DefaultStorage(filepath.Join("..", "..", "..", "e2e", "tests", "data", "storage-block-4-2-config.yaml"))
 
@@ -113,29 +105,6 @@ var _ = Describe("Storage controller medium tests", func() {
 		}
 		Expect(foundVolume).To(BeTrue())
 
-		By("Check that label and annotation propagated to pods...", func() {
-			podLabels := storageSS.Spec.Template.Labels
-			podAnnotations := storageSS.Spec.Template.Annotations
-
-			foundStorage := v1alpha1.Storage{}
-			Expect(k8sClient.Get(ctx, types.NamespacedName{
-				Name:      testobjects.StorageName,
-				Namespace: testobjects.YdbNamespace,
-			}, &foundStorage)).Should(Succeed())
-
-			foundStorageGenerationLabel := false
-			if podLabels[labels.StorageGeneration] == strconv.FormatInt(foundStorage.ObjectMeta.Generation, 10) {
-				foundStorageGenerationLabel = true
-			}
-			Expect(foundStorageGenerationLabel).To(BeTrue())
-
-			foundConfigurationChecksumAnnotation := false
-			if podAnnotations[annotations.ConfigurationChecksum] == annotations.GetSHA256Checksum(foundStorage.Spec.Configuration) {
-				foundConfigurationChecksumAnnotation = true
-			}
-			Expect(foundConfigurationChecksumAnnotation).To(BeTrue())
-		})
-
 		By("Check that args with --label propagated to pods...", func() {
 			podContainerArgs := storageSS.Spec.Template.Spec.Containers[0].Args
 			var labelArgKey string