Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add graceful shutdown to the plugin #57

Closed
gingersamurai opened this issue Aug 15, 2023 · 0 comments
Closed

feat: add graceful shutdown to the plugin #57

gingersamurai opened this issue Aug 15, 2023 · 0 comments
Assignees
@gingersamurai
Labels
enhancement New feature or request

Comments

@gingersamurai
Copy link
Contributor

Feature Request

Describe the Feature Request

Now plugin shutdowns after jaegerGrpc.Serve() end, but Jaeger support .Close() method to graceful shutdown
Describe Preferred Solution

Implement .Close() method

Additional Context

Ability to shutdown plugin was added in Jaeger 1.27 here.
@gingersamurai gingersamurai added the enhancement New feature or request label Aug 15, 2023
@gingersamurai gingersamurai self-assigned this Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gingersamurai gingersamurai

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gingersamurai