Skip to content

Commit a40b363

Browse files
author
Phillip Wittrock
authored
Merge pull request kubernetes-sigs#168 from pwittrock/master
Fix controller generator issue where used title Resource instead of p…
2 parents c9c5cd9 + 78a6ed0 commit a40b363

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

cmd/apiregister-gen/generators/controller_generator.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,8 @@ func (d *controllerGenerator) Imports(c *generator.Context) []string {
5656
func (d *controllerGenerator) Finalize(context *generator.Context, w io.Writer) error {
5757
temp := template.Must(template.New("controller-template").Funcs(
5858
template.FuncMap{
59-
"title": strings.Title,
59+
"title": strings.Title,
60+
"plural": inflect.NewDefaultRuleset().Pluralize,
6061
},
6162
).Parse(ControllerAPITemplate))
6263
return temp.Execute(w, d.controller)
@@ -95,7 +96,7 @@ func New{{.Target.Kind}}Controller(config *rest.Config, si *sharedinformers.Shar
9596
c.Informers.WorkerQueues = map[string]*controller.QueueWorker{}
9697
}
9798
c.Informers.WorkerQueues["{{.Target.Kind}}"] = queue
98-
si.Factory.{{title .Target.Group}}().{{title .Target.Version}}().{{title .Resource}}().Informer().
99+
si.Factory.{{title .Target.Group}}().{{title .Target.Version}}().{{plural .Target.Kind }}().Informer().
99100
AddEventHandler(&controller.QueueingEventHandler{q, nil, false})
100101
return c
101102
}
@@ -191,7 +192,8 @@ func (d *allControllerGenerator) Imports(c *generator.Context) []string {
191192
func (d *allControllerGenerator) Finalize(context *generator.Context, w io.Writer) error {
192193
temp := template.Must(template.New("all-controller-template").Funcs(
193194
template.FuncMap{
194-
"title": strings.Title,
195+
"title": strings.Title,
196+
"plural": inflect.NewDefaultRuleset().Pluralize,
195197
},
196198
).Parse(AllControllerAPITemplate))
197199
return temp.Execute(w, d)

0 commit comments

Comments
 (0)