From ce9e45fbf7103d6e5b6024518909a6081771b2b0 Mon Sep 17 00:00:00 2001 From: Riley Jones <78179109+rileyajones@users.noreply.github.com> Date: Tue, 13 Dec 2022 03:43:58 +0000 Subject: [PATCH] Linked Time: Replace view encapsulation hack with `::ng-deep` (#6103) ## Motivation for features / changes #6092 was pretty hacky and also didn't work internally ## Technical description of changes Apparently the pseudo selector ::ng-deep temporarily removes encapsulation and generally works better anyway. ## Screenshots of UI changes It works in OSS ![image](https://user-images.githubusercontent.com/78179109/207216000-4993095f-a419-4c10-9463-c57b7420e5dd.png) It works internally ![image](https://user-images.githubusercontent.com/78179109/207215848-fab8de51-38a6-45b5-a550-2f021306ef77.png) ## Detailed steps to verify changes work correctly (as executed by you) See #6092 --- .../line_chart_component.ng.html | 1 - .../line_chart_v2/line_chart_component.scss | 8 ++++ .../widgets/line_chart_v2/sub_view/BUILD | 1 - .../sub_view/line_chart_unencapsulated.ts | 46 ------------------- .../line_chart_v2/sub_view/sub_view_module.ts | 3 -- 5 files changed, 8 insertions(+), 51 deletions(-) delete mode 100644 tensorboard/webapp/widgets/line_chart_v2/sub_view/line_chart_unencapsulated.ts diff --git a/tensorboard/webapp/widgets/line_chart_v2/line_chart_component.ng.html b/tensorboard/webapp/widgets/line_chart_v2/line_chart_component.ng.html index 44da6e0fd39..3ee1d977938 100644 --- a/tensorboard/webapp/widgets/line_chart_v2/line_chart_component.ng.html +++ b/tensorboard/webapp/widgets/line_chart_v2/line_chart_component.ng.html @@ -23,7 +23,6 @@ #overlayTarget="cdkOverlayOrigin" cdkOverlayOrigin > -