Simplifications in BezierWalkerEditor

Author: yasirkula

Plugins/BezierSolution/Editor/BezierWalkerEditor.cs

@@ -1,12 +1,13 @@
-using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
 using UnityEditor;
 using UnityEngine;
 
 namespace BezierSolution.Extras
 {
-	public abstract class BezierWalkerEditor : Editor
+	public abstract class BezierWalkerEditor<T> : Editor where T : BezierWalker
 	{
-		protected Object[] walkers;
+		protected T[] walkers;
 
 		private bool simulateInEditor;
 		private double lastUpdateTime;
@@ -18,7 +19,7 @@ public abstract class BezierWalkerEditor : Editor
 
 		private void OnEnable()
 		{
-			walkers = targets;
+			walkers = Array.ConvertAll( targets, ( e ) => (T) e );
 
 			if( simulateInEditor )
 				StartSimulateInEditor();
@@ -75,9 +76,9 @@ protected virtual void SaveInitialData()
 
 			for( int i = 0; i < walkers.Length; i++ )
 			{
-				initialPositions.Add( ( (Component) walkers[i] ).transform.position );
-				initialRotations.Add( ( (Component) walkers[i] ).transform.rotation );
-				initialNormalizedTs.Add( ( (BezierWalker) walkers[i] ).NormalizedT );
+				initialPositions.Add( walkers[i].transform.position );
+				initialRotations.Add( walkers[i].transform.rotation );
+				initialNormalizedTs.Add( walkers[i].NormalizedT );
 			}
 
 			hasInitialData = true;
@@ -89,9 +90,9 @@ protected virtual void RestoreInitialData()
 			{
 				if( walkers[i] )
 				{
-					( (Component) walkers[i] ).transform.position = initialPositions[i];
-					( (Component) walkers[i] ).transform.rotation = initialRotations[i];
-					( (BezierWalker) walkers[i] ).NormalizedT = initialNormalizedTs[i];
+					walkers[i].transform.position = initialPositions[i];
+					walkers[i].transform.rotation = initialRotations[i];
+					walkers[i].NormalizedT = initialNormalizedTs[i];
 				}
 			}
 		}
@@ -114,7 +115,7 @@ private void SimulateInEditor()
 		protected virtual void Simulate( float deltaTime )
 		{
 			for( int i = 0; i < walkers.Length; i++ )
-				( (BezierWalker) walkers[i] ).Execute( deltaTime );
+				walkers[i].Execute( deltaTime );
 		}
 	}
 }

Plugins/BezierSolution/Editor/BezierWalkerLocomotionEditor.cs

@@ -6,7 +6,7 @@ namespace BezierSolution.Extras
 {
 	[CustomEditor( typeof( BezierWalkerLocomotion ) )]
 	[CanEditMultipleObjects]
-	public class BezierWalkerLocomotionEditor : BezierWalkerEditor
+	public class BezierWalkerLocomotionEditor : BezierWalkerEditor<BezierWalkerLocomotion>
 	{
 		private int tailSaveDataStartIndex;
 
@@ -17,7 +17,7 @@ protected override void SaveInitialData()
 
 			for( int i = 0; i < walkers.Length; i++ )
 			{
-				List<Transform> tail = ( (BezierWalkerLocomotion) walkers[i] ).Tail;
+				List<Transform> tail = walkers[i].Tail;
 				for( int j = 0; j < tail.Count; j++ )
 				{
 					initialPositions.Add( tail[j].position );
@@ -35,7 +35,7 @@ protected override void RestoreInitialData()
 			{
 				if( walkers[i] )
 				{
-					List<Transform> tail = ( (BezierWalkerLocomotion) walkers[i] ).Tail;
+					List<Transform> tail = walkers[i].Tail;
 					for( int j = 0; j < tail.Count; j++, index++ )
 					{
 						tail[j].position = initialPositions[index];
@@ -48,7 +48,7 @@ protected override void RestoreInitialData()
 		protected override void Simulate( float deltaTime )
 		{
 			for( int i = 0; i < walkers.Length; i++ )
-				( (BezierWalkerLocomotion) walkers[i] ).walker.Execute( deltaTime );
+				walkers[i].walker.Execute( deltaTime );
 
 			base.Simulate( deltaTime );
 		}

Plugins/BezierSolution/Editor/BezierWalkerWithSpeedEditor.cs

@@ -4,7 +4,7 @@ namespace BezierSolution.Extras
 {
 	[CustomEditor( typeof( BezierWalkerWithSpeed ) )]
 	[CanEditMultipleObjects]
-	public class BezierWalkerWithSpeedEditor : BezierWalkerEditor
+	public class BezierWalkerWithSpeedEditor : BezierWalkerEditor<BezierWalkerWithSpeed>
 	{
 	}
 }

Plugins/BezierSolution/Editor/BezierWalkerWithTimeEditor.cs

@@ -4,7 +4,7 @@ namespace BezierSolution.Extras
 {
 	[CustomEditor( typeof( BezierWalkerWithTime ) )]
 	[CanEditMultipleObjects]
-	public class BezierWalkerWithTimeEditor : BezierWalkerEditor
+	public class BezierWalkerWithTimeEditor : BezierWalkerEditor<BezierWalkerWithTime>
 	{
 	}
 }