Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timer should have a finished state #14

Open
dirkam opened this issue Dec 24, 2020 · 3 comments
Open

Timer should have a finished state #14

dirkam opened this issue Dec 24, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@dirkam
Copy link

dirkam commented Dec 24, 2020

Timer should have a finished state. Right now it's only possible to check this with a few checks, including the remaining time, which can go below zero (probably it should set itself to 0 instead of going below zero).

@yashovardhan99 yashovardhan99 linked a pull request Dec 24, 2020 that will close this issue
@yashovardhan99 yashovardhan99 removed a link to a pull request Dec 24, 2020
@yashovardhan99
Copy link
Owner

Hi, Thanks for opening the issue. Ignore the earlier comment and linked PR, it was meant for #13
I no longer actually maintain this library actively but if enough people are still using it, I might consider updating it with these requested changes.

@yashovardhan99 yashovardhan99 added the enhancement New feature or request label Dec 24, 2020
@yashovardhan99
Copy link
Owner

If it's possible for you, you can open a PR yourself with your desired changes, and I will be sure to merge it!

@shmilon
Copy link

shmilon commented Aug 4, 2022

timer split should show descending order and also should show time format. Please, can you add it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants