[Bug] Resolver supported by Yarn v1 does not work in Yarn v2

[mariusmarais]

Describe the bug

A resolver supported by Yarn 1 is not supported by Yarn 2. I cannot personally parse the error well enough to understand what exactly isn't supported.

To Reproduce

Yarn 1 works:

mkdir y1
cd y1
yarn init
yarn add @chakra-ui/core@1.0.0-next.6
# works \o/

Yarn 2 does not:

/tmp ❯❯❯ mkdir y2
/tmp ❯❯❯ cd y2
/t/y2 ❯❯❯ yarn init -2
yarn init v1.22.4
Resolving berry to a url...
Downloading https://github.com/yarnpkg/berry/raw/master/packages/berry-cli/bin/berry.js...
Saving it into /private/tmp/y2/.yarn/releases/yarn-berry.js...
Updating /private/tmp/y2/.yarnrc.yml...
Done!
{
  name: 'y2'
}
✨  Done in 3.87s.
/t/y2 ❯❯❯ yarn --version                                                                                                                                                                                                                                                                                     
2.1.1
/t/y2 ❯❯❯ yarn add @chakra-ui/core@1.0.0-next.6
➤ YN0000: ┌ Resolution step
➤ YN0001: │ Error: @types/styled-system__core@npm:@peduarte/styled-system__core isn't supported by any available resolver
    at i.getResolverByDescriptor (/private/tmp/y2/.yarn/releases/yarn-berry.js:2:266590)
    at i.bindDescriptor (/private/tmp/y2/.yarn/releases/yarn-berry.js:2:266044)
    at /private/tmp/y2/.yarn/releases/yarn-berry.js:2:288133
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async Promise.all (index 18)
    at async ne.resolveEverything (/private/tmp/y2/.yarn/releases/yarn-berry.js:2:287456)
    at async /private/tmp/y2/.yarn/releases/yarn-berry.js:2:304371
    at async f.startTimerPromise (/private/tmp/y2/.yarn/releases/yarn-berry.js:2:313773)
    at async ne.install (/private/tmp/y2/.yarn/releases/yarn-berry.js:2:304005)
➤ YN0000: └ Completed in 0.71s
➤ YN0000: Failed with errors in 0.72s

Reproduction

const installPromise = packageJsonAndInstall({
dependencies: {
  [`@chakra-ui/core`]: `1.0.0-next.6`
}
});

await expect(installPromise).resolves.toBeTruthy();

Environment if relevant (please complete the following information):

• OS: OSX 10.15.5
• Node version 12.18.2
• Yarn version 2.1.1

[yarnbot]

The reproduction case in your issue seems broken (ie it neither pass nor fail due to throwing an unmanaged exception):

Error: Command failed: /usr/bin/node /github/workspace/scripts/actions/../run-yarn.js install

➤ YN0000: ┌ Resolution step
::group::Resolution step
➤ YN0001: │ Error: @types/styled-system__core@npm:@peduarte/styled-system__core isn't supported by any available resolver
    at MultiResolver.getResolverByDescriptor (/github/workspace/packages/yarnpkg-core/sources/MultiResolver.ts:67:13)
    at MultiResolver.bindDescriptor (/github/workspace/packages/yarnpkg-core/sources/MultiResolver.ts:31:27)
    at /github/workspace/packages/yarnpkg-core/sources/Project.ts:795:34
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async Promise.all (index 15)
    at Project.resolveEverything (/github/workspace/packages/yarnpkg-core/sources/Project.ts:772:35)
    at /github/workspace/packages/yarnpkg-core/sources/Project.ts:1464:7
    at StreamReport.startTimerPromise (/github/workspace/packages/yarnpkg-core/sources/StreamReport.ts:248:14)
    at Project.install (/github/workspace/packages/yarnpkg-core/sources/Project.ts:1447:5)
::endgroup::
➤ YN0000: └ Completed in 5.54s
➤ YN0000: Failed with errors in 5.54s

    at ChildProcess.exithandler (child_process.js:303:12)
    at ChildProcess.emit (events.js:315:20)
    at maybeClose (internal/child_process.js:1021:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:286:5)

Remember: any non-Jest exceptions will cause the test to be reported as broken. If you expect something to pass without throwing, you must wrap it into something like await expect(...).resolves.toBeTruthy(). If you instead expect something to throw, you need to wrap it into await expect(...).rejects.toThrow().

[yarnbot]

This issue reproduces on master:

Error: expect(received).resolves.toBeTruthy()

Received promise rejected instead of resolved
Rejected to value: [Error: Command failed: /usr/bin/node /github/workspace/scripts/actions/../run-yarn.js install

➤ YN0000: ┌ Resolution step
::group::Resolution step
➤ YN0001: │ Error: @types/styled-system__core@npm:@peduarte/styled-system__core isn't supported by any available resolver
    at MultiResolver.getResolverByDescriptor (/github/workspace/packages/yarnpkg-core/sources/MultiResolver.ts:67:13)
    at MultiResolver.bindDescriptor (/github/workspace/packages/yarnpkg-core/sources/MultiResolver.ts:31:27)
    at /github/workspace/packages/yarnpkg-core/sources/Project.ts:795:34
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async Promise.all (index 15)
    at Project.resolveEverything (/github/workspace/packages/yarnpkg-core/sources/Project.ts:772:35)
    at /github/workspace/packages/yarnpkg-core/sources/Project.ts:1464:7
    at StreamReport.startTimerPromise (/github/workspace/packages/yarnpkg-core/sources/StreamReport.ts:248:14)
    at Project.install (/github/workspace/packages/yarnpkg-core/sources/Project.ts:1447:5)
::endgroup::
➤ YN0000: └ Completed in 1.6s
➤ YN0000: Failed with errors in 1.61s
]
    at expect (/github/workspace/.yarn/cache/expect-npm-24.8.0-8c7640c562-0ac41999f0.zip/node_modules/expect/build/index.js:138:15)
    at module.exports (evalmachine.<anonymous>:8:7)
    at /github/workspace/.yarn/cache/@arcanis-sherlock-npm-1.0.38-d4f5e2dbf3-63f998598d.zip/node_modules/@arcanis/sherlock/lib/executeRepro.js:56:19
    at executeInTempDirectory (/github/workspace/.yarn/cache/@arcanis-sherlock-npm-1.0.38-d4f5e2dbf3-63f998598d.zip/node_modules/@arcanis/sherlock/lib/executeRepro.js:17:22)
    at Object.executeRepro (/github/workspace/.yarn/cache/@arcanis-sherlock-npm-1.0.38-d4f5e2dbf3-63f998598d.zip/node_modules/@arcanis/sherlock/lib/executeRepro.js:24:18)
    at ExecCommand.execute (/github/workspace/.yarn/cache/@arcanis-sherlock-npm-1.0.38-d4f5e2dbf3-63f998598d.zip/node_modules/@arcanis/sherlock/lib/commands/exec.js:25:59)
    at async ExecCommand.validateAndExecute (/github/workspace/.yarn/cache/clipanion-npm-2.0.0-rc.16-b9444aaf89-a57989414f.zip/node_modules/clipanion/lib/advanced/Command.js:161:26)
    at async Cli.run (/github/workspace/.yarn/cache/clipanion-npm-2.0.0-rc.16-b9444aaf89-a57989414f.zip/node_modules/clipanion/lib/advanced/Cli.js:74:24)
    at async Cli.runExit (/github/workspace/.yarn/cache/clipanion-npm-2.0.0-rc.16-b9444aaf89-a57989414f.zip/node_modules/clipanion/lib/advanced/Cli.js:83:28)

[yarnbot]

This issue reproduces on master:

Error: expect(received).resolves.toBeTruthy()

Received promise rejected instead of resolved
Rejected to value: [Error: Command failed: /usr/bin/node /github/workspace/scripts/actions/../run-yarn.js install

➤ YN0000: ┌ Resolution step
::group::Resolution step
➤ YN0001: │ Error: @types/styled-system__core@npm:@peduarte/styled-system__core isn't supported by any available resolver
    at MultiResolver.getResolverByDescriptor (/github/workspace/packages/yarnpkg-core/sources/MultiResolver.ts:67:13)
    at MultiResolver.bindDescriptor (/github/workspace/packages/yarnpkg-core/sources/MultiResolver.ts:31:27)
    at /github/workspace/packages/yarnpkg-core/sources/Project.ts:795:34
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async Promise.all (index 15)
    at Project.resolveEverything (/github/workspace/packages/yarnpkg-core/sources/Project.ts:772:35)
    at /github/workspace/packages/yarnpkg-core/sources/Project.ts:1464:7
    at StreamReport.startTimerPromise (/github/workspace/packages/yarnpkg-core/sources/StreamReport.ts:248:14)
    at Project.install (/github/workspace/packages/yarnpkg-core/sources/Project.ts:1447:5)
::endgroup::
➤ YN0000: └ Completed in 1.27s
➤ YN0000: Failed with errors in 1.27s
]
    at expect (/github/workspace/.yarn/cache/expect-npm-24.8.0-8c7640c562-0ac41999f0.zip/node_modules/expect/build/index.js:138:15)
    at module.exports (evalmachine.<anonymous>:8:7)
    at /github/workspace/.yarn/cache/@arcanis-sherlock-npm-1.0.38-d4f5e2dbf3-63f998598d.zip/node_modules/@arcanis/sherlock/lib/executeRepro.js:56:19
    at executeInTempDirectory (/github/workspace/.yarn/cache/@arcanis-sherlock-npm-1.0.38-d4f5e2dbf3-63f998598d.zip/node_modules/@arcanis/sherlock/lib/executeRepro.js:17:22)
    at Object.executeRepro (/github/workspace/.yarn/cache/@arcanis-sherlock-npm-1.0.38-d4f5e2dbf3-63f998598d.zip/node_modules/@arcanis/sherlock/lib/executeRepro.js:24:18)
    at ExecCommand.execute (/github/workspace/.yarn/cache/@arcanis-sherlock-npm-1.0.38-d4f5e2dbf3-63f998598d.zip/node_modules/@arcanis/sherlock/lib/commands/exec.js:25:59)
    at async ExecCommand.validateAndExecute (/github/workspace/.yarn/cache/clipanion-npm-2.0.0-rc.16-b9444aaf89-a57989414f.zip/node_modules/clipanion/lib/advanced/Command.js:161:26)
    at async Cli.run (/github/workspace/.yarn/cache/clipanion-npm-2.0.0-rc.16-b9444aaf89-a57989414f.zip/node_modules/clipanion/lib/advanced/Cli.js:74:24)
    at async Cli.runExit (/github/workspace/.yarn/cache/clipanion-npm-2.0.0-rc.16-b9444aaf89-a57989414f.zip/node_modules/clipanion/lib/advanced/Cli.js:83:28)

[mariusmarais]

Specific package causing problem: https://www.npmjs.com/package/@chakra-ui/styled-system/v/1.0.0-next.6

Specific format causing problem: npm:@peduarte/styled-system__core

Updated repro:

await expect(packageJsonAndInstall({
  dependencies: {
    ["@types/styled-system__core"]: "npm:@peduarte/styled-system__core",
  }
})).resolves.toBeTruthy();

[arcanis]

Yeah, it's missing a range. Should be npm:@peduarte/styled-system__core@* or similar. We should relax the descriptor parsing.

[mariusmarais]

Thanks, adding a resolution with @* appended works around the issue.

[Amareis]

yarn add react@npm:@pika/react is failing too in 2.1.1.

 YN0000: ┌ Resolution step
➤ YN0001: │ Error: react@npm:@pika/react isn't supported by any available resolver
    at i.getResolverByDescriptor (/home/joe/work/ppldo-front/.yarn/releases/yarn-2.1.1.cjs:2:266590)
    at i.bindDescriptor (/home/joe/work/ppldo-front/.yarn/releases/yarn-2.1.1.cjs:2:266044)
    at Promise.all.s.map (/home/joe/work/ppldo-front/.yarn/releases/yarn-2.1.1.cjs:2:288133)
➤ YN0000: └ Completed
➤ YN0000: Failed with errors in 0.14s

And yarn add react@npm:@pika/react@* failing too:

 YN0000: ┌ Resolution step
➤ YN0001: │ Error: Assertion failed: The package could not be found
    at C (/home/joe/work/ppldo-front/.yarn/releases/yarn-2.1.1.cjs:2:290431)
    at I.w.push (/home/joe/work/ppldo-front/.yarn/releases/yarn-2.1.1.cjs:2:292848)
    at I (/home/joe/work/ppldo-front/.yarn/releases/yarn-2.1.1.cjs:2:293562)
    at E (/home/joe/work/ppldo-front/.yarn/releases/yarn-2.1.1.cjs:2:290551)
    at I.B.push (/home/joe/work/ppldo-front/.yarn/releases/yarn-2.1.1.cjs:2:293419)
    at I (/home/joe/work/ppldo-front/.yarn/releases/yarn-2.1.1.cjs:2:294303)
    at E (/home/joe/work/ppldo-front/.yarn/releases/yarn-2.1.1.cjs:2:290551)
    at project (/home/joe/work/ppldo-front/.yarn/releases/yarn-2.1.1.cjs:2:294382)
    at ne.resolveEverything (/home/joe/work/ppldo-front/.yarn/releases/yarn-2.1.1.cjs:2:294409)
    at process._tickCallback (internal/process/next_tick.js:68:7)
➤ YN0000: └ Completed in 3.64s
➤ YN0000: Failed with errors in 3.65s

[mariusmarais]

@Amareis I'm unsure of a command line option that works, but I was able to workaround by:

1. Adding to package.json:

"resolutions": {
  "@types/styled-system__core": "npm:@peduarte/styled-system__core@*"
}

2. Then running yarn add without the version specified.

[Amareis]

Yep, that works!