Do not expose core data error in protocol

kudoleh · kudoleh · commit 71769fcd972a · 2023-03-01T23:37:21.000+01:00
diff --git a/ExampleMVVM/Data/PersistentStorages/MoviesResponseStorage/CoreDataMoviesResponseStorage.swift b/ExampleMVVM/Data/PersistentStorages/MoviesResponseStorage/CoreDataMoviesResponseStorage.swift
@@ -41,7 +41,7 @@ final class CoreDataMoviesResponseStorage {
 
 extension CoreDataMoviesResponseStorage: MoviesResponseStorage {
 
-    func getResponse(for requestDto: MoviesRequestDTO, completion: @escaping (Result<MoviesResponseDTO?, CoreDataStorageError>) -> Void) {
+    func getResponse(for requestDto: MoviesRequestDTO, completion: @escaping (Result<MoviesResponseDTO?, Error>) -> Void) {
         coreDataStorage.performBackgroundTask { context in
             do {
                 let fetchRequest = self.fetchRequest(for: requestDto)
diff --git a/ExampleMVVM/Data/PersistentStorages/MoviesResponseStorage/MoviesResponseStorage.swift b/ExampleMVVM/Data/PersistentStorages/MoviesResponseStorage/MoviesResponseStorage.swift
@@ -8,6 +8,6 @@
 import Foundation
 
 protocol MoviesResponseStorage {
-    func getResponse(for request: MoviesRequestDTO, completion: @escaping (Result<MoviesResponseDTO?, CoreDataStorageError>) -> Void)
+    func getResponse(for request: MoviesRequestDTO, completion: @escaping (Result<MoviesResponseDTO?, Error>) -> Void)
     func save(response: MoviesResponseDTO, for requestDto: MoviesRequestDTO)
 }

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,6 @@`
`8`	`8`	`import Foundation`
`9`	`9`
`10`	`10`	`protocol MoviesResponseStorage {`
`11`		`- func getResponse(for request: MoviesRequestDTO, completion: @escaping (Result<MoviesResponseDTO?, CoreDataStorageError>) -> Void)`
	`11`	`+ func getResponse(for request: MoviesRequestDTO, completion: @escaping (Result<MoviesResponseDTO?, Error>) -> Void)`
`12`	`12`	`func save(response: MoviesResponseDTO, for requestDto: MoviesRequestDTO)`
`13`	`13`	`}`