✨ allow extra field and fix boolean default

Author: yanyongyu

codegen/parser/schemas/bool_schema.py

@@ -2,6 +2,7 @@
 
 from ...source import Source
 from .schema import BoolSchema
+from ..utils import build_boolean
 
 
 def build_bool_schema(source: Source) -> BoolSchema:
@@ -13,6 +14,8 @@ def build_bool_schema(source: Source) -> BoolSchema:
     return BoolSchema(
         title=data.title,
         description=data.description,
-        default=data.default,
+        default=build_boolean(data.default)
+        if data.default is not None
+        else data.default,
         examples=data.examples or (data.example and [data.example]),
     )

codegen/parser/utils.py

@@ -70,6 +70,12 @@ def concat_snake_name(*names: str) -> str:
     return "_".join(snake_case(name) for name in names)
 
 
+def build_boolean(value: bool | str) -> bool:
+    if isinstance(value, bool):
+        return value
+    return value.lower() not in {"false", "f", "no", "n", "0"}
+
+
 def build_class_name(name: str) -> str:
     config = get_config()
     class_name = fix_reserved_words(pascal_case(name))

codegen/templates/models/models.py.jinja

@@ -8,13 +8,15 @@ See https://github.com/github/rest-api-description for more information.
 
 from __future__ import annotations
 
+from pydantic import BaseModel, Extra
+
 {% for model in models %}
 {% for import_ in model.get_model_imports() %}
 {{ import_ }}
 {% endfor %}
 {% endfor %}
 
-class GitHubRestModel(BaseModel, allow_population_by_field_name=True):
+class GitHubRestModel(BaseModel, extra=Extra.allow, allow_population_by_field_name=True):
     ...
 
 {# model #}

githubkit/rest/models.py

@@ -15,7 +15,9 @@
 from githubkit.utils import UNSET, Unset
 
 
-class GitHubRestModel(BaseModel, allow_population_by_field_name=True):
+class GitHubRestModel(
+    BaseModel, extra=Extra.allow, allow_population_by_field_name=True
+):
     ...
 
 
@@ -1739,6 +1741,10 @@ class OrganizationSecretScanningAlert(GitHubRestModel):
         description="The time that push protection was bypassed in ISO 8601 format: `YYYY-MM-DDTHH:MM:SSZ`.",
         default=UNSET,
     )
+    resolution_comment: Union[Unset, Union[str, None]] = Field(
+        description="The comment that was optionally added when this alert was closed",
+        default=UNSET,
+    )
 
 
 class AdvancedSecurityActiveCommittersUser(GitHubRestModel):
@@ -6708,6 +6714,10 @@ class DependencyGraphDiffItems(GitHubRestModel):
     vulnerabilities: List[DependencyGraphDiffItemsPropVulnerabilitiesItems] = Field(
         default=...
     )
+    scope: Literal["unknown", "runtime", "development"] = Field(
+        description="Where the dependency is utilized. `development` means that the dependency is only utilized in the development environment. `runtime` means that the dependency is utilized at runtime and in the development environment.",
+        default=...,
+    )
 
 
 class DependencyGraphDiffItemsPropVulnerabilitiesItems(GitHubRestModel):
@@ -9482,6 +9492,10 @@ class SecretScanningAlert(GitHubRestModel):
         description="The time that push protection was bypassed in ISO 8601 format: `YYYY-MM-DDTHH:MM:SSZ`.",
         default=UNSET,
     )
+    resolution_comment: Union[Unset, Union[str, None]] = Field(
+        description="The comment that was optionally added when this alert was closed",
+        default=UNSET,
+    )
 
 
 class SecretScanningLocationCommit(GitHubRestModel):
@@ -12431,7 +12445,7 @@ class ReposOwnerRepoAutolinksPostBody(GitHubRestModel):
     )
     is_alphanumeric: Union[Unset, bool] = Field(
         description="Whether this autolink reference matches alphanumeric characters. If true, the `<num>` parameter of the `url_template` matches alphanumeric characters `A-Z` (case insensitive), `0-9`, and `-`. If false, this autolink reference only matches numeric characters.",
-        default="true",
+        default=True,
     )
 
 
@@ -15284,6 +15298,10 @@ class ReposOwnerRepoSecretScanningAlertsAlertNumberPatchBody(GitHubRestModel):
         description="**Required when the `state` is `resolved`.** The reason for resolving the alert.",
         default=UNSET,
     )
+    resolution_comment: Union[Unset, Union[str, None]] = Field(
+        description="Sets an optional comment when closing an alert. Must be null when changing `state` to `open`.",
+        default=UNSET,
+    )
 
 
 class ReposOwnerRepoStatusesShaPostBody(GitHubRestModel):

githubkit/rest/repos.py

@@ -714,7 +714,7 @@ def create_autolink(
         data: Unset = UNSET,
         key_prefix: str,
         url_template: str,
-        is_alphanumeric: Union[Unset, bool] = "true",
+        is_alphanumeric: Union[Unset, bool] = True,
     ) -> "Response[Autolink]":
         ...
 
@@ -760,7 +760,7 @@ async def async_create_autolink(
         data: Unset = UNSET,
         key_prefix: str,
         url_template: str,
-        is_alphanumeric: Union[Unset, bool] = "true",
+        is_alphanumeric: Union[Unset, bool] = True,
     ) -> "Response[Autolink]":
         ...
 
@@ -7847,6 +7847,7 @@ def update_information_about_pages_site(
             error_models={
                 "422": ValidationError,
                 "400": BasicError,
+                "409": BasicError,
             },
         )
 
@@ -8010,6 +8011,7 @@ async def async_update_information_about_pages_site(
             error_models={
                 "422": ValidationError,
                 "400": BasicError,
+                "409": BasicError,
             },
         )
 
@@ -8192,6 +8194,7 @@ def delete_pages_site(
             error_models={
                 "422": ValidationError,
                 "404": BasicError,
+                "409": BasicError,
             },
         )
 
@@ -8208,6 +8211,7 @@ async def async_delete_pages_site(
             error_models={
                 "422": ValidationError,
                 "404": BasicError,
+                "409": BasicError,
             },
         )
 

githubkit/rest/secret_scanning.py

@@ -314,6 +314,7 @@ def update_alert(
                 None, Literal["false_positive", "wont_fix", "revoked", "used_in_tests"]
             ],
         ] = UNSET,
+        resolution_comment: Union[Unset, Union[str, None]] = UNSET,
     ) -> "Response[SecretScanningAlert]":
         ...
 
@@ -375,6 +376,7 @@ async def async_update_alert(
                 None, Literal["false_positive", "wont_fix", "revoked", "used_in_tests"]
             ],
         ] = UNSET,
+        resolution_comment: Union[Unset, Union[str, None]] = UNSET,
     ) -> "Response[SecretScanningAlert]":
         ...
 

githubkit/rest/types.py

@@ -1108,6 +1108,7 @@ class OrganizationSecretScanningAlertType(TypedDict):
     push_protection_bypassed: NotRequired[Union[bool, None]]
     push_protection_bypassed_by: NotRequired[Union[None, SimpleUserType]]
     push_protection_bypassed_at: NotRequired[Union[datetime, None]]
+    resolution_comment: NotRequired[Union[str, None]]
 
 
 class AdvancedSecurityActiveCommittersUserType(TypedDict):
@@ -4940,6 +4941,7 @@ class DependencyGraphDiffItemsType(TypedDict):
     license_: Union[str, None]
     source_repository_url: Union[str, None]
     vulnerabilities: List[DependencyGraphDiffItemsPropVulnerabilitiesItemsType]
+    scope: Literal["unknown", "runtime", "development"]
 
 
 class DependencyGraphDiffItemsPropVulnerabilitiesItemsType(TypedDict):
@@ -7081,6 +7083,7 @@ class SecretScanningAlertType(TypedDict):
     push_protection_bypassed: NotRequired[Union[bool, None]]
     push_protection_bypassed_by: NotRequired[Union[None, SimpleUserType]]
     push_protection_bypassed_at: NotRequired[Union[datetime, None]]
+    resolution_comment: NotRequired[Union[str, None]]
 
 
 class SecretScanningLocationCommitType(TypedDict):
@@ -10854,6 +10857,7 @@ class ReposOwnerRepoSecretScanningAlertsAlertNumberPatchBodyType(TypedDict):
     resolution: NotRequired[
         Union[None, Literal["false_positive", "wont_fix", "revoked", "used_in_tests"]]
     ]
+    resolution_comment: NotRequired[Union[str, None]]
 
 
 class ReposOwnerRepoStatusesShaPostBodyType(TypedDict):