-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add More Valid Architectures #21
Conversation
@giantramen Adding As a side note: This project is using almost the same configuration as PromiseKit (https://github.com/mxcl/PromiseKit) especially regarding the build configuration and platforms support. |
I see that PromiseKit only has i386 and x86_64 for VALID_ARCHS, but according to the documentation that shouldn't work: Is there something I'm missing here or is the documentation just misleading? |
Here's the doc about
It seems that |
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
========================================
+ Coverage 99.43% 100% +0.56%
========================================
Files 7 4 -3
Lines 176 51 -125
========================================
- Hits 175 51 -124
+ Misses 1 0 -1
Continue to review full report at Codecov.
|
Removed 64 bit device required so it will build for 32 bit iPhones.
Removed the Valid Architectures. I was confused because in the empty state Xcode shows i386 and x86_64, even though it will build for all architectures. |
Updated for Swift 4
Removed 64 bit device required so it will build for 32 bit iPhones.
Any chance you can merge this in? Would like to point back at a real release. |
@giantramen Sorry for the very late, your last commits and I don't know why. I merge it now, thank you for your contribution! |
Add armv7s armv7 and arm64 so it will build for 32 bit
iPhones.