You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The function name to_int64 as well as the comment following it don't make clear that the original encoding of the uint64 is preserved. In this sense it could be better to have a distinction between a value conversion (for example when UINT_MAX is added), and a reinterpretation of one type as another (like the pointer cast happening here https://github.com/yallop/ocaml-integers/blob/master/src/unsigned_stubs.c#L197).
For the function name maybe as_int64 could be a good option.
The text was updated successfully, but these errors were encountered:
https://github.com/yallop/ocaml-integers/blob/master/src/unsigned.mli#L93-L94
The function name
to_int64
as well as the comment following it don't make clear that the original encoding of theuint64
is preserved. In this sense it could be better to have a distinction between a value conversion (for example when UINT_MAX is added), and a reinterpretation of one type as another (like the pointer cast happening here https://github.com/yallop/ocaml-integers/blob/master/src/unsigned_stubs.c#L197).For the function name maybe
as_int64
could be a good option.The text was updated successfully, but these errors were encountered: