Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc] Centralize and remove redundant casts to validation code #55

Open
amirebrahimi opened this issue Nov 2, 2021 · 1 comment
Open

[Misc] Centralize and remove redundant casts to validation code #55

amirebrahimi opened this issue Nov 2, 2021 · 1 comment
Labels
good first issue Good for newcomers

Comments

@amirebrahimi
Copy link
Collaborator

If you search for int( you'll find casts throughout a lot of the codebase. This might be left-over from before _params_validation() was added. The task is to remove these redundant casts and add a few assertions/additional tests as needed.
@amirebrahimi amirebrahimi added the good first issue Good for newcomers label Nov 2, 2021
@anonymousr007
Copy link

Hi @amirebrahimi, I am Rishabh from India, recently contributed in Cirq and Pennylane and I want to make a PR for this issue, can you please elaborate little bit more?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amirebrahimi @anonymousr007