feat: Implement optional email results #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
The changes look good; I will review this as soon as I can. Thanks! |
hpacleb
reviewed
Feb 1, 2023
Collaborator
hpacleb
left a comment
hpacleb
left a comment
There was a problem hiding this comment.
Updating the README file on how to use this optional function would be appreciated
hpacleb
reviewed
Feb 1, 2023
Co-authored-by: Harvey Christian Pacleb <kimpacleb@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Owner
|
@hpacleb missing period suggestion merged. Do you approve this PR? |
yajra
changed the title
hpacleb
approved these changes
Feb 7, 2023
Collaborator
hpacleb
left a comment
hpacleb
left a comment
There was a problem hiding this comment.
I'll just add the filename changes in another PR so this can be merged.
|
I'm going to add my 2 cents into this PR, I think users may want to customize the email template sent per datatable and not a generic one. But not really sure. |
yajra
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this can be useful when export takes too long.
There is an optional email-to prop you can add to your button if you want the job to email the report once it's done.