Multiplayer Notification Fix for random Termination #2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-final static variables being null. Instead moved all state to Worker specific architecture. Also switched to Android based localization because core-based one can be unavailable to worker.
Added missing androidX declaration (neccessary for newer Gradle versions) Updated Gradle for new Android Studio Version
|
Please add an explaination on how to translate these strings in the wiki |
This was referenced Jun 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request hopefully fixes the problem that the multiplayer turn notifier randomly stops running. The problem seems to have been a reliance on global variables. Because of the Worker architecture of the notifier, the Unciv app context may not exist when it is called by the WorkManager. In that case all global variables may have default or null values.
To remove the dependence on global variables, the turn notifier has been rewritten to store its settings in a Data object that is part of the WorkManager API.
Also all dependence on the .tr() lib has been removed. The .tr() call relies heavily on Unciv.Current being initialized, which is not guaranteed because Android might have unloaded the app from RAM.
As a result, I had to switch the notifier over to Android's native i18n lib, which uses a completely different set of files for its texts. :(