Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari having bug when scroll to top #113

Open
youwei91 opened this issue Jun 20, 2018 · 6 comments
Open

Safari having bug when scroll to top #113

youwei91 opened this issue Jun 20, 2018 · 6 comments

Comments

@youwei91
Copy link

youwei91 commented Jun 20, 2018

I met a bug is when in Safari, when I tap to scroll to top, it will leave a huge blank space

screen shot 2018-06-20 at 2 29 30 pm

After I investigate is due to the STATUS_FIXED is not respond correctly. At Sticky.jsx, line365, the position value should change base on STATUS_FIXED value, but it somehow not changing in Safari when I scrolling fast to top, I try to add another handling window.pageYOffset for it, it fixed the bug.
position: this.state.status === STATUS_FIXED && window.pageYOffset ? 'fixed' : 'relative',
I hope you guys can update it or maybe find another way to fix it, thanks.

@redonkulus
Copy link
Contributor

Closing old bugs, please re-open if still an issue on latest Safari.

@andrickd
Copy link

I can reproduce this issue in Safari 14.1.1 using the most current version (3.1.0 at time of writing) - this issue should be reopened.

@redonkulus
Copy link
Contributor

Thanks for spotting, will re-open. Feel free to open a PR to fix if you like.

@redonkulus redonkulus reopened this Jun 30, 2021
@strangeliu
Copy link

Still exist

@AmmadKhanM
Copy link

still Exist

1 similar comment
@ericmaicon
Copy link

still Exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants