Ability to route some metrics only for given adapter #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, @killondark, thanks a lot for the pull request! However, @Keallar was first with #37, so I'm closing this pull request in favor of it. But I believe that this feature is still far from being complete for all possible real world use cases, so please try it, and feel free to open another pull request with any additions or fixes! |
Envek
reviewed
Oct 1, 2024
| @@ -38,6 +38,16 @@ def group(group_name) | |||
| @group = nil | |||
| end | |||
|
|
|||
| def adapter(adapter_name) | |||
| @adapter_name = adapter_name | |||
| yield if block_given? | |||
There was a problem hiding this comment.
Love that you thought about usage with groups and very curious about this yield. How you planned to use it?
It may worth to be cherry-picked into separate pull request!
There was a problem hiding this comment.
I did it for this:
adapter :prometheus do
include_group :sidekiq
endInitialize the group configuration, before or after that declare that this is a group of only this adapter: sidekiq group only for prometheus adapter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Check my feature realization «Ability to route some metrics only for given adapter»