You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems that by mistake I chose the ambigous name worker for use in metric or label names. It led to my confusion several times (e.g. in #11 (comment) or #13 (comment))
…it helps to understand the basic entities in Sidekiq’s universe:
A job is a unit of work in your Ruby application
A queue is a list of jobs which are ready to execute right now
A process is a Sidekiq process with one or more threads for executing jobs.
NB: I never use the term worker as it is nebulous and confusing. Use process, thread or job class so your meaning is clear.
However, this is apparently a breaking change, so we probably should find a trade-off between the passion to name things right and not breaking things too much.
It seems that by mistake I chose the ambigous name
worker
for use in metric or label names. It led to my confusion several times (e.g. in #11 (comment) or #13 (comment))Even @mperham recommends against using it in https://www.mikeperham.com/2021/04/20/a-tour-of-the-sidekiq-api/:
However, this is apparently a breaking change, so we probably should find a trade-off between the passion to name things right and not breaking things too much.
Code of interest is here:
yabeda-sidekiq/lib/yabeda/sidekiq.rb
Lines 21 to 46 in 91c8f4e
README lists metrics here: https://github.com/yabeda-rb/yabeda-sidekiq/blob/91c8f4ed23a2687b396ac64add8236f3ed16f0cc/README.md#metrics
The text was updated successfully, but these errors were encountered: