Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent form submission on time input control icon click #45

Merged
merged 1 commit into from
Mar 2, 2020
Merged

prevent form submission on time input control icon click #45

merged 1 commit into from
Mar 2, 2020

Conversation

taras-danyliuk
Copy link

If there is no type prop on button, forms treats this button as submit button(

@y0c y0c merged commit ab238b4 into y0c:dev Mar 2, 2020
@taras-danyliuk taras-danyliuk deleted the fix/prevent-form-submission branch March 2, 2020 14:10
@taras-danyliuk
Copy link
Author

@y0c Will you be able to update npm with this changes?
I would really appreciate it)

@y0c
Copy link
Owner

y0c commented Mar 2, 2020

@taras-danyliuk 1.0.2 released

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (dev@a1f1be6). Learn more about missing BASE report.
Report is 32 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             dev       #45   +/-   ##
=======================================
  Coverage       ?   100.00%           
=======================================
  Files          ?        26           
  Lines          ?       638           
  Branches       ?        71           
=======================================
  Hits           ?       638           
  Misses         ?         0           
  Partials       ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants