-
Notifications
You must be signed in to change notification settings - Fork 81
build(deps): Bump ystdlib-cpp
to the commit before the outcome
library was added.
#811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): Bump ystdlib-cpp
to the commit before the outcome
library was added.
#811
Conversation
WalkthroughThis pull request updates the commit reference for the ystdlib-cpp dependency across multiple components. The changes include updating the submodule commit in the core directory, modifying dependency source information in the tasks file, and adjusting the version reference in the developer guide documentation. All updates ensure that the project now points to the new commit of ystdlib-cpp. Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
⏰ Context from checks skipped due to timeout of 90000ms (5)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ystdlib-cpp
version to before the addition of the outcome library.ystdlib-cpp
to the commit before outcome
library addition.
ystdlib-cpp
to the commit before outcome
library addition.ystdlib-cpp
to the commit before the outcome
library addition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the PR title, how about:
build(deps): Bump ystdlib-cpp to the commit before the `outcome` library was added.
ystdlib-cpp
to the commit before the outcome
library addition.outcome
library was added.
outcome
library was added.ystdlib-cpp
to the commit before the outcome
library was added.
…brary was added. (y-scope#811)
Description
Bump
ystdlib-cpp
version so that we can useystdlib::containers::Array
.We do not bump to the newest version because currently CLP build will break upon the
find_package(outcome)
call inystdlib-cpp
. We will do so after we switch to useTask
to manage all our dependencies.Checklist
breaking change.
Validation performed