Skip to content

Conversation

Bill-hbrhbr
Copy link
Contributor

@Bill-hbrhbr Bill-hbrhbr commented Apr 10, 2025

Description

Bump ystdlib-cpp version so that we can use ystdlib::containers::Array.

We do not bump to the newest version because currently CLP build will break upon the find_package(outcome) call in ystdlib-cpp. We will do so after we switch to use Task to manage all our dependencies.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

  • No code changes.

@Bill-hbrhbr Bill-hbrhbr requested a review from a team as a code owner April 10, 2025 16:24
Copy link
Contributor

coderabbitai bot commented Apr 10, 2025

Walkthrough

This pull request updates the commit reference for the ystdlib-cpp dependency across multiple components. The changes include updating the submodule commit in the core directory, modifying dependency source information in the tasks file, and adjusting the version reference in the developer guide documentation. All updates ensure that the project now points to the new commit of ystdlib-cpp.

Changes

Files Change Summary
components/core/submodules/ystdlib-cpp, deps-tasks.yml, docs/src/dev-guide/components-core/index.md Updated the ystdlib-cpp dependency. The submodule commit was changed from d1b4ae0e6cc614dfbe6e4570719d41d9d4f93a3a to 2ac17579d12c48e2f45d4688a10bcabb5becb466 (or abbreviated 2ac1757 in docs). Updates include changes to the commit reference, dependency variables, and documentation entries.

Possibly related PRs

Suggested reviewers

  • davidlion
  • LinZhihao-723

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2b80383 and d1f59e5.

📒 Files selected for processing (3)
  • components/core/submodules/ystdlib-cpp (1 hunks)
  • deps-tasks.yml (1 hunks)
  • docs/src/dev-guide/components-core/index.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: ubuntu-jammy-static-linked-bins
  • GitHub Check: centos-stream-9-static-linked-bins
  • GitHub Check: ubuntu-jammy-lint
  • GitHub Check: ubuntu-jammy-dynamic-linked-bins
  • GitHub Check: centos-stream-9-dynamic-linked-bins
🔇 Additional comments (3)
components/core/submodules/ystdlib-cpp (1)

1-1: Subproject Commit Reference Update

The commit reference has been updated to 2ac17579d12c48e2f45d4688a10bcabb5becb466. Please verify that the new commit corresponds to the version of ystdlib-cpp prior to the addition of the outcome library, as intended by the PR objectives. Additionally, ensure that any integration relying on ystdlib::containers::Array is thoroughly tested.

docs/src/dev-guide/components-core/index.md (1)

47-47: Dependency Version Update Verification

The ystdlib-cpp dependency reference has been updated to commit 2ac1757. Please verify that this is the intended version for enabling the ystdlib::containers::Array functionality as described in the PR objectives.

deps-tasks.yml (1)

492-493: Dependency Identifier Consistency Check

The SRC_NAME is updated to "ystdlib-cpp-2ac17579d12c48e2f45d4688a10bcabb5becb466" while the SRC_URL now points to https://github.com/y-scope/ystdlib-cpp/archive/2ac1757.zip. Please confirm that using the full commit hash in SRC_NAME alongside the abbreviated hash in the URL is intentional and consistent with the project's versioning strategy.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Bill-hbrhbr Bill-hbrhbr changed the title build(deps): Bump ystdlib-cpp version to before the addition of the outcome library. build(deps): Bump ystdlib-cpp to the commit before outcome library addition. Apr 10, 2025
@Bill-hbrhbr Bill-hbrhbr changed the title build(deps): Bump ystdlib-cpp to the commit before outcome library addition. build(deps): Bump ystdlib-cpp to the commit before the outcome library addition. Apr 10, 2025
Copy link
Member

@kirkrodrigues kirkrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the PR title, how about:

build(deps): Bump ystdlib-cpp to the commit before the `outcome` library was added.

@Bill-hbrhbr Bill-hbrhbr changed the title build(deps): Bump ystdlib-cpp to the commit before the outcome library addition. build(deps): Bump ystdlib-cpp to the commit before the outcome library was added. Apr 10, 2025
@Bill-hbrhbr Bill-hbrhbr changed the title build(deps): Bump ystdlib-cpp to the commit before the outcome library was added. build(deps): Bump ystdlib-cpp to the commit before the outcome library was added. Apr 10, 2025
@Bill-hbrhbr Bill-hbrhbr merged commit 52c15dc into y-scope:main Apr 10, 2025
25 of 27 checks passed
@Bill-hbrhbr Bill-hbrhbr deleted the bump-ystdlib-cpp-version branch April 10, 2025 16:32
anlowee pushed a commit to anlowee/clp that referenced this pull request Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants