Addressed code-rabbit review points.

Author: jackluo923

.github/workflows/clp-core-build.yaml

@@ -147,45 +147,6 @@ jobs:
             ${{github.event_name != 'pull_request' && github.ref == 'refs/heads/main'}}
           token: "${{secrets.GITHUB_TOKEN}}"
 
-  manylinux_2_28-binaries:
-    # Run if the ancestor jobs succeeded OR they were skipped and clp was changed.
-    if: >-
-      success()
-      || (!cancelled() && !failure() && needs.filter-relevant-changes.outputs.clp_changed == 'true')
-    needs:
-      - "centos-stream-9-deps-image"
-      - "filter-relevant-changes"
-    strategy:
-      matrix:
-        use_shared_libs: [true, false]
-    name: "centos-stream-9-${{matrix.use_shared_libs == true && 'dynamic' || 'static'}}-linked-bins"
-    continue-on-error: true
-    runs-on: "ubuntu-latest"
-    steps:
-      - uses: "actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683"
-        with:
-          submodules: "recursive"
-
-      - name: "Work around actions/runner-images/issues/6775"
-        run: "chown $(id -u):$(id -g) -R ."
-        shell: "bash"
-
-      - uses: "./.github/actions/run-on-image"
-        env:
-          OS_NAME: "centos-stream-9"
-        with:
-          image_name: "${{env.DEPS_IMAGE_NAME_PREFIX}}${{env.OS_NAME}}"
-          use_published_image: >-
-            ${{needs.filter-relevant-changes.outputs.centos_stream_9_image_changed == 'false'
-            || (github.event_name != 'pull_request' && github.ref == 'refs/heads/main')}}
-          run_command: >-
-            CLP_CORE_MAX_PARALLELISM_PER_BUILD_TASK=$(getconf _NPROCESSORS_ONLN) task deps:core
-            && python3 /mnt/repo/components/core/tools/scripts/utils/build-and-run-unit-tests.py
-            ${{matrix.use_shared_libs == true && '--use-shared-libs' || ''}}
-            --source-dir /mnt/repo/components/core
-            --build-dir /mnt/repo/components/core/build
-            --num-jobs $(getconf _NPROCESSORS_ONLN)
-
   centos-stream-9-binaries:
     # Run if the ancestor jobs succeeded OR they were skipped and clp was changed.
     if: >-

components/core/tools/docker-images/clp-env-base-musllinux_1_2-aarch64/Dockerfile

@@ -8,7 +8,7 @@ COPY ./tools/scripts/lib_install ./tools/scripts/lib_install
 RUN ./tools/scripts/lib_install/musllinux_1_2/install-all.sh
 
 # Remove cached files
-RUN apk cache clean && rm -rf /var/cache/apk/* /tmp/* /var/tmp/*
+RUN apk cache clean --all && rm -rf /var/cache/apk/* /tmp/* /var/tmp/*
 
 # NOTE: Don't flatten the image or else we'll lose any environment modifications from the base
 # image.

components/core/tools/docker-images/clp-env-base-musllinux_1_2-x86_64/Dockerfile

@@ -8,7 +8,7 @@ COPY ./tools/scripts/lib_install ./tools/scripts/lib_install
 RUN ./tools/scripts/lib_install/musllinux_1_2/install-all.sh
 
 # Remove cached files
-RUN apk cache clean && rm -rf /var/cache/apk/* /tmp/* /var/tmp/*
+RUN apk cache clean --all && rm -rf /var/cache/apk/* /tmp/* /var/tmp/*
 
 # NOTE: Don't flatten the image or else we'll lose any environment modifications from the base
 # image.

docs/src/dev-guide/tooling-containers.md

@@ -8,9 +8,11 @@ To build an image locally, run the `build.sh` script in the image's directory.
 
 ## clp-core-dependencies-<arch>-manylinux_2_28
 
-Images containing the dependencies necessary to build CLP core in a [musllinux_1_2][musllinux_1_2] environment (aarch64 or x86).
-Binaries built on musllinux_1_2 (based on Alpine Linux 3.22) are expected to be compatible with other
-distros using musl 1.2+, including:
+Images containing the dependencies necessary to build CLP core in a [manylinux_2_28][manylinux_2_28]
+environment (aarch64 or x86).
+
+Binaries built on manylinux_2_28 (based on AlmaLinux 8) are expected to be compatible with other
+distros using glibc 2.28+, including:
 
 * CentOS/RHEL 8+
 * Debian 10+
@@ -59,7 +61,6 @@ distros using musl 1.2, including:
   components/core/tools/docker-images/clp-env-base-musllinux_1_2-x86_64
   ```
 
-
 ## clp-core-dependencies-x86-centos-stream-9
 
 An image containing the dependencies necessary to build CLP core in a CentOS Stream 9 x86
@@ -138,4 +139,4 @@ environment.
 [exe-ubuntu-jammy]: https://github.com/y-scope/clp/pkgs/container/clp%2Fclp-execution-x86-ubuntu-jammy
 [gh-packages]: https://github.com/orgs/y-scope/packages?repo_name=clp
 [manylinux_2_28]: https://github.com/pypa/manylinux?tab=readme-ov-file#manylinux_2_28-almalinux-8-based
-[musllinux_1_2]: https://github.com/pypa/manylinux?tab=readme-ov-file#musllinux_1_2-alpine-linux-322-based-313-compatible
+[musllinux_1_2]: https://github.com/pypa/manylinux?tab=readme-ov-file#musllinux_1_2-alpine-linux-322-based-313-compatible