Skip to content

Commit b56ac35

Browse files
committed
Add session token constant and use constants in error messages.
1 parent 92c6ab6 commit b56ac35

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

components/clp-py-utils/clp_py_utils/s3_utils.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
AWS_ENDPOINT = "amazonaws.com"
2727
AWS_ENV_VAR_ACCESS_KEY_ID = "AWS_ACCESS_KEY_ID"
2828
AWS_ENV_VAR_SECRET_ACCESS_KEY = "AWS_SECRET_ACCESS_KEY"
29+
AWS_ENV_VAR_SESSION_TOKEN = "AWS_SESSION_TOKEN"
2930

3031

3132
def _get_session_credentials(aws_profile: Optional[str] = None) -> Optional[S3Credentials]:
@@ -87,7 +88,7 @@ def get_credential_env_vars(config: S3Config) -> Dict[str, str]:
8788
}
8889
aws_session_token = aws_credentials.session_token
8990
if aws_session_token is not None:
90-
env_vars["AWS_SESSION_TOKEN"] = aws_session_token
91+
env_vars[f"{AWS_ENV_VAR_SESSION_TOKEN}"] = aws_session_token
9192
return env_vars
9293

9394

@@ -147,11 +148,12 @@ def generate_container_auth_options(
147148
)
148149
else:
149150
raise ValueError(
150-
"AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY environment variables not set"
151+
f"{AWS_ENV_VAR_ACCESS_KEY_ID} and {AWS_ENV_VAR_SECRET_ACCESS_KEY} "
152+
"environment variables not set"
151153
)
152-
if os.getenv("AWS_SESSION_TOKEN"):
154+
if os.getenv(f"{AWS_ENV_VAR_SESSION_TOKEN}"):
153155
raise ValueError(
154-
"AWS_SESSION_TOKEN not supported for environmental variable credentials."
156+
f"{AWS_ENV_VAR_SESSION_TOKEN} not supported for environmental variable credentials."
155157
)
156158

157159
return (config_mount, credentials_env_vars)

0 commit comments

Comments
 (0)