Skip to content

Commit b18c2f3

Browse files
committed
fix: resolved issues raised by coderabbit
1 parent 9112825 commit b18c2f3

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed

components/core/CMakeLists.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,7 @@ if (CLP_USE_STATIC_LIBS)
7373
set(CLP_STATIC_LIBS_UNSUPPORTED_PLATFORM "macOS")
7474
elseif (EXISTS "/etc/centos-release")
7575
# For now, only manylinux_2_28 (AlmaLinux 8 based) supports static linking
76-
file(READ "/etc/centos-release" CENTOS_RELEASE_CONTENT)
77-
string(FIND "${CENTOS_RELEASE_CONTENT}" "AlmaLinux" ALMALINUX_FOUND)
78-
if(ALMALINUX_FOUND EQUAL -1)
76+
if(NOT "${CENTOS_RELEASE_CONTENT}" MATCHES "AlmaLinux")
7977
set(CLP_STATIC_LIBS_UNSUPPORTED_PLATFORM "CentOS")
8078
endif()
8179
endif()

components/core/tools/docker-images/clp-env-base-manylinux_2_28_aarch64/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM quay.io/pypa/manylinux_2_28_aarch64
1+
FROM quay.io/pypa/manylinux_2_28_aarch64:2025.06.25-1
22

33
# Binaries built on manylinux_2_28 (AlmaLinux 8 based) is expected to be
44
# compatible with other distros using glibc 2.28 or later, including:
@@ -10,7 +10,7 @@ FROM quay.io/pypa/manylinux_2_28_aarch64
1010
WORKDIR /root
1111

1212
RUN mkdir -p ./tools/scripts/lib_install
13-
ADD ./tools/scripts/lib_install ./tools/scripts/lib_install
13+
COPY ./tools/scripts/lib_install ./tools/scripts/lib_install
1414

1515
RUN ./tools/scripts/lib_install/manylinux_2_28/install-all.sh
1616

components/core/tools/docker-images/clp-env-base-manylinux_2_28_x86_64/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM quay.io/pypa/manylinux_2_28_x86_64
1+
FROM quay.io/pypa/manylinux_2_28_x86_64:2025.06.25-1
22

33
# Binaries built on manylinux_2_28 (AlmaLinux 8 based) is expected to be
44
# compatible with other distros using glibc 2.28 or later, including:
@@ -10,7 +10,7 @@ FROM quay.io/pypa/manylinux_2_28_x86_64
1010
WORKDIR /root
1111

1212
RUN mkdir -p ./tools/scripts/lib_install
13-
ADD ./tools/scripts/lib_install ./tools/scripts/lib_install
13+
COPY ./tools/scripts/lib_install ./tools/scripts/lib_install
1414

1515
RUN ./tools/scripts/lib_install/manylinux_2_28/install-all.sh
1616

components/core/tools/scripts/lib_install/manylinux_2_28/install-all.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@
33
# Exit on any error
44
set -e
55

6+
# Exit on failures hidden inside pipes (e.g., curl | tar)
7+
set -o pipefail
8+
69
# Error on undefined variable
710
set -u
811

0 commit comments

Comments
 (0)