fix(core): Drop fractional seconds from formatted timestamps used for S3 signed-URL generation (fixes #1131). (#1128)

haiqi96 · web-flow · commit b0a607fb8dcb · 2025-07-26T18:01:46.000-04:00
diff --git a/components/core/src/clp/aws/AwsAuthenticationSigner.cpp b/components/core/src/clp/aws/AwsAuthenticationSigner.cpp
@@ -91,7 +91,8 @@ auto is_unreserved_characters(char c) -> bool {
 
 auto get_formatted_timestamp_string(std::chrono::system_clock::time_point const& timestamp)
         -> string {
-    return fmt::format("{:%Y%m%dT%H%M%SZ}", timestamp);
+    auto const timestamp_secs = std::chrono::time_point_cast<std::chrono::seconds>(timestamp);
+    return fmt::format("{:%Y%m%dT%H%M%SZ}", timestamp_secs);
 }
 
 auto get_formatted_date_string(std::chrono::system_clock::time_point const& timestamp) -> string {

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,8 @@ auto is_unreserved_characters(char c) -> bool {`
`91`	`91`
`92`	`92`	`auto get_formatted_timestamp_string(std::chrono::system_clock::time_point const& timestamp)`
`93`	`93`	`-> string {`
`94`		`- return fmt::format("{:%Y%m%dT%H%M%SZ}", timestamp);`
	`94`	`+ auto const timestamp_secs = std::chrono::time_point_cast<std::chrono::seconds>(timestamp);`
	`95`	`+ return fmt::format("{:%Y%m%dT%H%M%SZ}", timestamp_secs);`
`95`	`96`	`}`
`96`	`97`
`97`	`98`	`auto get_formatted_date_string(std::chrono::system_clock::time_point const& timestamp) -> string {`