refactor(ffi): Resolve clang-tidy violations in ffi/utils.cpp. (#777)

Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>

Author: LinZhihao-723

components/core/src/clp/ffi/utils.cpp

@@ -61,6 +61,14 @@ auto validate_and_append_escaped_utf8_string(std::string_view src, std::string&
                 constexpr uint8_t cLargestControlCharacter{0x1F};
                 auto const byte{static_cast<uint8_t>(*it)};
                 if (cLargestControlCharacter >= byte) {
+                    // NOTE: This section can be replaced with the following without losing any
+                    // performance:
+                    // escaped_char = fmt::format("\\u00{:02x}", byte);
+                    // We should update it once `fmtlib` is fully integrated into the FFI library.
+
+                    // Necessary since implementations (besides `fmtlib`) that don't violate
+                    // `cppcoreguidelines-pro-type-vararg` have much worse performance.
+                    // NOLINTNEXTLINE(cppcoreguidelines-pro-type-vararg)
                     std::ignore = snprintf(buf.data(), buf.size(), "\\u00%02x", byte);
                     escaped_char = {buf.data(), buf.size() - 1};
                 } else {

lint-tasks.yml

@@ -269,7 +269,6 @@ tasks:
             - "{{.G_CORE_COMPONENT_DIR}}/src/clp/ffi/search/Subquery.hpp"
             - "{{.G_CORE_COMPONENT_DIR}}/src/clp/ffi/search/WildcardToken.cpp"
             - "{{.G_CORE_COMPONENT_DIR}}/src/clp/ffi/search/WildcardToken.hpp"
-            - "{{.G_CORE_COMPONENT_DIR}}/src/clp/ffi/utils.cpp"
             - "{{.G_CORE_COMPONENT_DIR}}/src/clp/FileDescriptor.cpp"
             - "{{.G_CORE_COMPONENT_DIR}}/src/clp/FileDescriptor.hpp"
             - "{{.G_CORE_COMPONENT_DIR}}/src/clp/FileDescriptorReader.cpp"