Ensure last ligature cell is updated #5209
Merged
+4
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes xtermjs#3288 Fixes xtermjs#5206 Part of microsoft/vscode#233005
|
This resolves a bunch of issues i was seeing with ligatures but there still seems to be one lingering issue. (notice the extra character over the > in => that shouldnt be there and the d in ::) |
|
@npezza93 I thought that was fixed by this as the issue was the last cell wasn't getting its content cleared out (so it would remain after scrolling). Would need a repro case to investigate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3288
Fixes #5206
Part of microsoft/vscode#233005