From 81d6c43900f25b76b7332c03237f9fb81403b10a Mon Sep 17 00:00:00 2001 From: Abdallah Samman Date: Tue, 4 Dec 2018 17:13:03 +0200 Subject: [PATCH] Add pre-commit hook to eslint javascript code; import nes.min.css globaly in stories; --- .eslintrc.json | 2 +- .storybook/config.js | 2 ++ docs/balloons.stories.js | 4 +--- docs/buttons.stories.js | 4 +--- docs/containers.stories.js | 4 +--- docs/icons.stories.js | 4 +--- docs/inputs.stories.js | 4 +--- docs/table.stories.js | 4 +--- package.json | 7 +++---- 9 files changed, 12 insertions(+), 23 deletions(-) diff --git a/.eslintrc.json b/.eslintrc.json index 6f675643..7ea33023 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -1,3 +1,3 @@ { "extends": "airbnb-base" -} \ No newline at end of file +} diff --git a/.storybook/config.js b/.storybook/config.js index a8fc685f..cffac937 100644 --- a/.storybook/config.js +++ b/.storybook/config.js @@ -1,5 +1,7 @@ import { configure } from '@storybook/html'; +import '../css/nes.min.css' + // automatically import all files ending in *.stories.js const req = require.context('../docs', true, /.stories.js$/); function loadStories() { diff --git a/docs/balloons.stories.js b/docs/balloons.stories.js index a031a987..d9edb41b 100644 --- a/docs/balloons.stories.js +++ b/docs/balloons.stories.js @@ -1,6 +1,4 @@ -import { storiesOf } from '@storybook/html'; - -import '../css/nes.css'; +import { storiesOf } from '@storybook/html'; // eslint-disable-line import/no-extraneous-dependencies storiesOf('Balloons', module) .add('.balloon.from-left', () => '

Hello NES.css

') diff --git a/docs/buttons.stories.js b/docs/buttons.stories.js index ad7e0ed1..8cff4864 100644 --- a/docs/buttons.stories.js +++ b/docs/buttons.stories.js @@ -1,6 +1,4 @@ -import { storiesOf } from '@storybook/html'; - -import '../css/nes.css'; +import { storiesOf } from '@storybook/html'; // eslint-disable-line import/no-extraneous-dependencies storiesOf('Buttons', module) .add('button.btn', () => ' ') diff --git a/docs/containers.stories.js b/docs/containers.stories.js index a17022ea..0b179c74 100644 --- a/docs/containers.stories.js +++ b/docs/containers.stories.js @@ -1,6 +1,4 @@ -import { storiesOf } from '@storybook/html'; - -import '../css/nes.css'; +import { storiesOf } from '@storybook/html'; // eslint-disable-line import/no-extraneous-dependencies storiesOf('Containers', module) .add('.container.with-title', () => `
diff --git a/docs/icons.stories.js b/docs/icons.stories.js index a52c6496..be6a53fe 100644 --- a/docs/icons.stories.js +++ b/docs/icons.stories.js @@ -1,6 +1,4 @@ -import { storiesOf } from '@storybook/html'; - -import '../css/nes.css'; +import { storiesOf } from '@storybook/html'; // eslint-disable-line import/no-extraneous-dependencies storiesOf('Icons', module) .add('icon.twitter', () => '') diff --git a/docs/inputs.stories.js b/docs/inputs.stories.js index 7ca0f9b3..77f9f2a4 100644 --- a/docs/inputs.stories.js +++ b/docs/inputs.stories.js @@ -1,6 +1,4 @@ -import { storiesOf } from '@storybook/html'; - -import '../css/nes.css'; +import { storiesOf } from '@storybook/html'; // eslint-disable-line import/no-extraneous-dependencies storiesOf('Inputs', module) .add('input.radio', () => ` diff --git a/docs/table.stories.js b/docs/table.stories.js index 3d6e6508..ad91d679 100644 --- a/docs/table.stories.js +++ b/docs/table.stories.js @@ -1,6 +1,4 @@ -import { storiesOf } from '@storybook/html'; - -import '../css/nes.css'; +import { storiesOf } from '@storybook/html'; // eslint-disable-line import/no-extraneous-dependencies storiesOf('Tables', module) .add('table.table', () => ` diff --git a/package.json b/package.json index 89f8452e..aa8e5e88 100644 --- a/package.json +++ b/package.json @@ -33,6 +33,7 @@ "homepage": "https://github.com/BcRikko/NES.css#readme", "devDependencies": { "@storybook/html": "^4.0.11", + "babel-loader": "^8.0.4", "autoprefixer": "^9.1.5", "clean-css-cli": "^4.2.1", "eslint": "^5.9.0", @@ -64,7 +65,8 @@ "npm run build", "git add ./css", "git add" - ] + ], + "*.js": ["eslint .", "git add"] }, "prettier": { "printWidth": 100 @@ -85,8 +87,5 @@ "at-rule-no-unknown": null, "scss/at-rule-no-unknown": true } - }, - "dependencies": { - "babel-loader": "^8.0.4" } }