Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require argparse on Python 2.7 #61

Open
twm opened this issue Feb 25, 2020 · 0 comments
Open

Don't require argparse on Python 2.7 #61

twm opened this issue Feb 25, 2020 · 0 comments

Comments

@twm
Copy link

twm commented Feb 25, 2020

The dependency on argparse requires it on all Python 2 versions:

uwsgitop/setup.py

Lines 15 to 17 in 423ab88

install_requires=[
'argparse;python_version<"3"',
],

However argparse is part of the standard library in Python 2.7. The dependency should be

    install_requires=[
        'argparse;python_version<"2.7"',
    ],

This would prevent pip install from complaining like this:

...
  Found existing installation: argparse 1.2.1
    Not uninstalling argparse at /usr/lib/python2.7, as it is in the standard library.
    Can't uninstall 'argparse'. No files were found to uninstall.
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant